Does a generated Insertable property for a nullable column have to be optional?

[adrianmisko]

Given a schema that has a nullable column:

create table authors(name varchar(255) primary key, stage_name varchar(255));

The generated insertable is:

    export interface Insertable {
      /**
      * **authors.name**
      * - `varchar` in database
      * - `NOT NULL`, no default
      */
      name: string | db.Parameter<string> | db.SQLFragment;
      /**
      * **authors.stage_name**
      * - `varchar` in database
      * - Nullable, no default
      */
      stage_name?: string | db.Parameter<string> | null | db.DefaultType | db.SQLFragment;
    }

Does the stage_name property have to be optional? This causes the following code to pass:

  const authors: s.authors.Insertable[] = [
    { name: 'Homer' },
  ]
  db.insert('authors', authors).run(pool);

even when using exactOptionalPropertyTypes.

I might forget to include an optional property and the compiler won't complain. That would not be the case if I the property was:

      stage_name:
        | string
        | db.Parameter<string>
        | null
        | db.DefaultType
        | db.SQLFragment

Then, an explicit null would be required:

  const authors: s.authors.Insertable[] = [
    { name: 'Homer', stage_name: null },
  ]

Is there a reason generated properties for Insertables are optional? I know that there are cases where you'd want that - generated values, values set by triggers. However, I think it should be null for "usual" nullable column. I don't know about backwards compatibility though.

Kinda related to #25

[remidewitte]

If you need this behavior, you might just use Required<Insertable>.

const authors: Required<s.authors.Insertable>[] = [
    { name: 'Homer', stage_name: null },
  ]