#1234 Protoype Access in :: Operator

[geraldalewis]

Issue #1234: Applying a splat to a prototype using :: applies the splat to the wrong object
Opened by: @Dykam
Date opened: March 25, 2011
Milestone: 1.2

Thanks to @michaelficarra for pointing to a solution and review!

Dykam's illustrative code:

A.prototype.method array... # Compiles correctly
A::method array... # Compiles incorrectly

var _ref;
(_ref = A.prototype).method.apply(_ref, array); // Correct
A.prototype.method.apply(A, array); // Incorrect

Solution: Adding an intermediary prototype Access node between the class and the method within the grammar.

I have some questions regarding some possible refinements posted in the src/ commit.

This issue ties into a larger issue on how :: is handled ( with respect to @ ) -- I will open a new issue that addresses the super-issue within two days.

[geraldalewis]

Here's a full diff of the entire patch (since the diff in Commits <> only shows the changes between the last two commits).

[Dykam]

Nice to see progress :] I wonder, why do you gist a diff and not commit to a fork?

[geraldalewis]

@Dykam I will if that makes life easier for the collabs or owner; just didn't seem like a big enough change to warrant another branch?

[michaelficarra]

I see all 3 commits and a combined diff. No idea what you guys are talking about.

[Dykam]

The diff didn't get on the mail, so I looked over it, never mind.

[michaelficarra]

To be a little less confusing:

class C
  method: -> @nonce
  nonce: nonce

arr = []
eq nonce, C::method arr... # should be applied to `C::`

[geraldalewis]

Yes -- that looks better. I'll update in a moment :)

[michaelficarra]

Awesome patch, @geraldalewis. LGTM.

[geraldalewis]

Thanks to you @michaelficarra :)

[jashkenas]

Gorgeous patch.