This repository was archived by the owner on Jul 20, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
[WIP] Allow configuration of what commits are checked #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8134209
to
46f5c0d
Compare
- Add test suite for `get-config` - Fix `get-config` to handle merging nested `gpg` property correctly
6578a87
to
cb0e2a9
Compare
Update existing test suites to handle changes made in modules to retrieve and use YAML config.
- Add test cases to exercise the web flow ignore logic - Fix implementation to return `success` even when ignoring web-flow failures
Add a few rudimentary tests for web flow ignore logic in `reduce-statuses`.
- Fix `create-commit` test helper to put the `login` property correctly under the `committer` property, not under `commit` - Update `get-commits` module to return the entire entry object for each commit, not just the `commit` property - Update unit tests to reflect that change
Closing in favor of cleaning up some stuff before attempting this again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41 and closes #53