Skip to content
This repository was archived by the owner on Jul 20, 2019. It is now read-only.

[WIP] Allow configuration of what commits are checked #43

Closed
wants to merge 8 commits into from

Conversation

jarrodldavis
Copy link
Owner

@jarrodldavis jarrodldavis commented Sep 30, 2017

  • Allow commits made using GitHub web-flow buttons (such as "Merge pull request" and "Update branch") to be ignored by GPG verification checks.
  • Allow requiring only the last commit of a pull request to be signed.

Closes #41 and closes #53

@jarrodldavis jarrodldavis temporarily deployed to probot-gpg-dev-pr-43 September 30, 2017 21:05 Inactive
@jarrodldavis jarrodldavis temporarily deployed to probot-gpg-dev-pr-43 September 30, 2017 22:02 Inactive
@jarrodldavis jarrodldavis changed the title [WIP] Allow ignoring GitHub merge commits [WIP] Allow ignoring GitHub web-flow commits Oct 1, 2017
@jarrodldavis jarrodldavis self-assigned this Oct 9, 2017
@jarrodldavis jarrodldavis added this to the v0.5.0 milestone Oct 10, 2017
@jarrodldavis jarrodldavis temporarily deployed to probot-gpg-dev October 14, 2017 20:43 Inactive
@jarrodldavis jarrodldavis reopened this Oct 14, 2017
@jarrodldavis jarrodldavis temporarily deployed to probot-gpg-dev-pr-43 October 14, 2017 21:54 Inactive
@jarrodldavis jarrodldavis changed the title [WIP] Allow ignoring GitHub web-flow commits [WIP] Allow configuration of what commits are checked Oct 14, 2017
- Add test suite for `get-config`
- Fix `get-config` to handle merging nested `gpg` property correctly
@jarrodldavis jarrodldavis temporarily deployed to probot-gpg-dev-pr-43 October 14, 2017 23:59 Inactive
Update existing test suites to handle changes made in modules to
retrieve and use YAML config.
@jarrodldavis jarrodldavis temporarily deployed to probot-gpg-dev-pr-43 October 15, 2017 03:16 Inactive
@jarrodldavis jarrodldavis temporarily deployed to probot-gpg-dev-pr-43 October 15, 2017 18:38 Inactive
- Add test cases to exercise the web flow ignore logic
- Fix implementation to return `success` even when ignoring web-flow
  failures
Add a few rudimentary tests for web flow ignore logic in
`reduce-statuses`.
@jarrodldavis jarrodldavis temporarily deployed to probot-gpg-dev-pr-43 October 17, 2017 02:24 Inactive
- Fix `create-commit` test helper to put the `login` property correctly
  under the `committer` property, not under `commit`
- Update `get-commits` module to return the entire entry object for each
  commit, not just the `commit` property
- Update unit tests to reflect that change
@jarrodldavis jarrodldavis added this to the v0.6.0 milestone Oct 21, 2017
@jarrodldavis
Copy link
Owner Author

Closing in favor of cleaning up some stuff before attempting this again.

@jarrodldavis jarrodldavis deleted the feature/repo-options branch October 21, 2017 23:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only require last commit to be signed Feature Request: Option to ignore merge commits for GPG check
1 participant