Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Jest 25 #664

Closed
sportshead opened this issue Apr 6, 2020 · 1 comment · Fixed by #679
Closed

Use Jest 25 #664

sportshead opened this issue Apr 6, 2020 · 1 comment · Fixed by #679
Labels
scope: dependencies Pull requests that update a dependency file solution: duplicate This issue or pull request already exists topic: Jest 25 Related to Jest 25 upgrade version: minor Increment the minor version when merged
Milestone
v0.14.0 - Dep Upg...

Comments

@sportshead
Copy link

Current Behavior

Jest 24.9

Desired Behavior

Jest 25

Suggested Solution

Upgrade to Jest 25

Who does this impact? Who is this for?

Everyone that uses Jest tests

Describe alternatives you've considered

Chai

Additional context

Maybe there will be breaking changes, I'm not sure so will have to check the source code
@agilgur5
Copy link
Collaborator

agilgur5 commented Apr 6, 2020

Duplicate of #497, #471, etc. Per my comment in #497 (comment), it is slightly breaking (hence why Jest used a major increment), so I'm holding off on upgrading it until ~v0.14

@agilgur5 agilgur5 closed this as completed Apr 6, 2020
@agilgur5 agilgur5 added solution: duplicate This issue or pull request already exists scope: dependencies Pull requests that update a dependency file version: minor Increment the minor version when merged labels Apr 6, 2020
@agilgur5 agilgur5 added this to the v0.14.0 milestone Apr 6, 2020
@agilgur5 agilgur5 added the topic: Jest 25 Related to Jest 25 upgrade label Apr 11, 2020
@agilgur5 agilgur5 mentioned this issue Apr 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: dependencies Pull requests that update a dependency file solution: duplicate This issue or pull request already exists topic: Jest 25 Related to Jest 25 upgrade version: minor Increment the minor version when merged
Projects
None yet
Milestone
v0.14.0 - Dep Upgrades - Jest 25 + No...
Development

Successfully merging a pull request may close this issue.

(deps): upgrade to Jest 25 agilgur5/tsdx
2 participants
@agilgur5 @sportshead