-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Node version support / add a warning to tsdx create #432
Comments
yup, sure thing. we can add an engines field https://stackoverflow.com/questions/29349684/how-can-i-specify-the-required-node-js-version-in-package-json and use something like |
Attempting to resolve this myself ✋ |
Mentioned this in #507 (comment) :
TSDX itself does not yet require Node 10+, I've specifically batched various dependencies' upgrades to Node 10 together to go into v0.14.0, which is a breaking change |
hmmm. whats the logic for still supporting node <10? |
@sw-yx I think you misinterpreted me. It should be formally dropped in a breaking change (same as all the deps that dropped it did -- it is breaking), which is what v0.14.0 is. It was not officially dropped before and is actually still supported (v0.14.0 is the next release with several breaking changes, mostly dependencies). |
ahh, makes perfect sense 👍🏽 |
Current Behavior
If you're on Node 8 you get errors when trying to run
tsdx create
, but the reason for the failures are unclear.Desired Behavior
When I run
tsdx create
it should tell me that my current Node version is not compatible.Suggested Solution
Add a deprecation warning for unsupported Node versions when running
tsdx create
, as well as add Node versions supported in theREADME.md
, and probably add aengines
attribute to the package.json describing the same limitations.Who does this impact? Who is this for?
All users.
Additional context
I only knew this by seeing the recent releases including this PR #426
The text was updated successfully, but these errors were encountered: