TypeError in tests for read_newlines and show-newlines (no newline argument)

[kloczek]

+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-jaraco-text-3.9.0-2.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-jaraco-text-3.9.0-2.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.13, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/tkloczko/rpmbuild/BUILD/jaraco.text-3.9.0, configfile: pytest.ini
plugins: cov-3.0.0
collected 26 items

jaraco/text/__init__.py ...............F.......                                                                                                                      [ 88%]
jaraco/text/layouts.py ..                                                                                                                                            [ 96%]
jaraco/text/show-newlines.py F                                                                                                                                       [100%]

================================================================================= FAILURES =================================================================================
_______________________________________________________________________ [doctest] text.read_newlines _______________________________________________________________________
604
605     >>> tmp_path = getfixture('tmp_path')
606     >>> filename = tmp_path / 'out.txt'
607     >>> _ = filename.write_text('foo\n', newline='')
UNEXPECTED EXCEPTION: TypeError("write_text() got an unexpected keyword argument 'newline'")
Traceback (most recent call last):
  File "/usr/lib64/python3.8/doctest.py", line 1336, in __run
    exec(compile(example.source, filename, "single",
  File "<doctest text.read_newlines[2]>", line 1, in <module>
TypeError: write_text() got an unexpected keyword argument 'newline'
/home/tkloczko/rpmbuild/BUILD/jaraco.text-3.9.0/jaraco/text/__init__.py:607: UnexpectedException
_______________________________________________________________ [doctest] text.show-newlines.report_newlines _______________________________________________________________
010
011     Report the newlines in the indicated file.
012
013     >>> tmp_path = getfixture('tmp_path')
014     >>> filename = tmp_path / 'out.txt'
015     >>> _ = filename.write_text('foo\nbar\n', newline='')
UNEXPECTED EXCEPTION: TypeError("write_text() got an unexpected keyword argument 'newline'")
Traceback (most recent call last):
  File "/usr/lib64/python3.8/doctest.py", line 1336, in __run
    exec(compile(example.source, filename, "single",
  File "<doctest text.show-newlines.report_newlines[2]>", line 1, in <module>
TypeError: write_text() got an unexpected keyword argument 'newline'
/home/tkloczko/rpmbuild/BUILD/jaraco.text-3.9.0/jaraco/text/show-newlines.py:15: UnexpectedException
========================================================================= short test summary info ==========================================================================
FAILED jaraco/text/__init__.py::text.read_newlines
FAILED jaraco/text/show-newlines.py::text.show-newlines.report_newlines
======================================================================= 2 failed, 24 passed in 0.11s =======================================================================

[bnavigator]

The newline parameter was only added in Python 3.10

https://docs.python.org/3/library/pathlib.html#pathlib.Path.write_text

@jaraco your CI jobs labeled "3.7" actually run pytest with Python 3.10:
https://github.com/jaraco/jaraco.text/runs/7820967297?check_suite_focus=true#step:5:14

[jaraco]

CI jobs labeled "3.7" actually run pytest with Python 3.10

I don't think it's my fault:

[jaraco]

It's a known bug apparently fixed with v4.