Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require nightly #225

Closed
Ekleog opened this issue Aug 21, 2018 · 2 comments
Closed

Do not require nightly #225

Ekleog opened this issue Aug 21, 2018 · 2 comments

Comments

@Ekleog
Copy link

Ekleog commented Aug 21, 2018

I've recently been told that setting the environment variable RUSTC_BOOTSTRAP=1 makes a standard rustc build able to build nightly-only crates. Maybe this could be used to not require a nightly build for compiling libcore?

@Ekleog Ekleog changed the title Do not require unstable Do not require nightly Aug 21, 2018
@janderholm
Copy link

I made a quick and dirty patch in xargo which set the environment variable and removed the warning print and it seems to work!

Since this is how rustc bootstrap does to build libstd I think it should be perfectly safe to do this.

@RalfJung
Copy link
Collaborator

See my comments in #275 (comment): I don't think we should do this, not unless the Rust Compiler team explicitly blesses us to do so. And I honestly doubt that will happen -- so, I am closing the issue as (likely) not actionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants