This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Implement routing configuration for Backstage server endpoint #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianrongzhang89
changed the title
jianrongzhang89
force-pushed
the
route
branch
from
aedcc10 to
b3a6c78
Compare
jianrongzhang89
changed the title
jianrongzhang89
force-pushed
the
route
branch
from
b3a6c78 to
a2401ca
Compare
jianrongzhang89
changed the title
jianrongzhang89
changed the title
gazarenkov
suggested changes
Nov 30, 2023
| @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| controller-gen.kubebuilder.io/version: v0.11.3 | |||
| @@ -187,7 +187,7 @@ var _ = Describe("Backstage controller", func() { | |||
| found := &appsv1.Deployment{} | |||
| Eventually(func() error { | |||
| // TODO to get name from default | |||
| return k8sClient.Get(ctx, types.NamespacedName{Namespace: ns, Name: "backstage"}, found) | |||
| return k8sClient.Get(ctx, types.NamespacedName{Namespace: ns, Name: "backstage-" + backstageName}, found) | |||
There was a problem hiding this comment.
Could you use Sprintf as we usually do?
There was a problem hiding this comment.
Sounds good :)
rm3l
reviewed
Dec 1, 2023
jianrongzhang89
force-pushed
the
route
branch
2 times, most recently
from
33cb07a to
383c941
Compare
jianrongzhang89
changed the title
jianrongzhang89
force-pushed
the
route
branch
2 times, most recently
from
1781469 to
b0d0381
Compare
jianrongzhang89
force-pushed
the
route
branch
from
b0d0381 to
b5306c8
Compare
rm3l
suggested changes
Dec 11, 2023
| @@ -129,6 +125,14 @@ func (r *BackstageReconciler) addBackendAuthEnvVar(ctx context.Context, backstag | |||
| Name: "APP_CONFIG_backend_auth_keys", | |||
| Value: `[{"secret": "$(BACKEND_SECRET)"}]`, | |||
| }) | |||
| // If a local PostGres DB is used, set POSTGRES_HOST env variable to the local PostGres DB service. | |||
| if !backstage.Spec.SkipLocalDb { | |||
There was a problem hiding this comment.
This file is more about handling the Backstage Backend Auth Key, not setting info about the local DB.
For better separation of concerns (and also to avoid Git conflicts since this file has changed a bit in #56 - see https://github.com/janus-idp/operator/pull/56/files#diff-d608a9323a5923cb475353e2f8d44c7571b93e49a4fd40f69ab7d1fcbef1801a), I'd suggest adding this env var elsewhere.. Maybe in BackstageReconciler.addEnvVars in backstage_controller.go?
There was a problem hiding this comment.
Sounds good. Moved to BackstageReconciler.addEnvVars.
1 task
|
Close and resubmit as another PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy an OpenShift route on OpenShift clusters.
Description
Changes made:
Note #1: supporting host and tls in the route via Backstage CR is not in the scope of this PR. Such work shall be done later as a separate PR after the data model has been finalized.
Note #2: unit test with isOpenShift=true is not included as OpenShift specific objects (routes, projects etc) are not currently supported by the envTest tool (see operator-framework/operator-sdk#4434).
Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer
Deploy the operator and backstage sample CR on an OpnenShift cluster and check if the OpenShift route for Backstage has been created.