Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to supply a custom http.Client #17

Open
janivihervas opened this issue Oct 31, 2018 · 0 comments
Open

Allow to supply a custom http.Client #17

janivihervas opened this issue Oct 31, 2018 · 0 comments
Milestone
2.2.0

Comments

@janivihervas
Copy link
Owner

Implementation is using http.DefaultClient. Implement a functionality to provide a custom http.Client to provide e.g. OpenCensus capability.

In order to keep backwards-compatibility, either export the client field or set it with a method like

cms := contentful.New(...)
cms.WithHttpClient(&http.Client{...})
@janivihervas janivihervas added this to the 2.2.0 milestone Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
1 participant
@janivihervas