Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic: support AMD using Vulkan #913

Closed
3 tasks done
Tracked by #905 ...
tikikun opened this issue Dec 8, 2023 · 13 comments
Closed
3 tasks done
Tracked by #905 ...

epic: support AMD using Vulkan #913

tikikun opened this issue Dec 8, 2023 · 13 comments
Assignees
Labels
P1: important Important feature / fix type: epic A major feature or initiative
Milestone

Comments

@tikikun
Copy link
Contributor

tikikun commented Dec 8, 2023

Problem
There is no build for AMD now on windows GPU

Success Criteria
Good performance for AMD GPU user on windows

Out of Scope

  • ROCm support

Subtasks

@tikikun tikikun added the type: feature request A new feature label Dec 8, 2023
@tikikun tikikun self-assigned this Dec 8, 2023
@tikikun tikikun added this to Menlo Dec 8, 2023
@dan-menlo dan-menlo added this to the Jan on Windows milestone Dec 11, 2023
@freelerobot freelerobot moved this to Triaged (Backlog) in Menlo Dec 15, 2023
@dan-menlo dan-menlo changed the title feat: AMD GPU on Windows feat: AMD GPU Dec 25, 2023
@tikikun tikikun moved this from Icebox to Planned in Menlo Dec 26, 2023
@tikikun
Copy link
Contributor Author

tikikun commented Dec 26, 2023

@tikikun
Copy link
Contributor Author

tikikun commented Dec 26, 2023

list of supported amd gpus

@freelerobot freelerobot changed the title feat: AMD GPU feat: support AMD GPUs (rocm, etc) Dec 28, 2023
@tikikun tikikun moved this from Planned to Icebox in Menlo Dec 29, 2023
@freelerobot freelerobot added the P1: important Important feature / fix label Jan 8, 2024
@tikikun tikikun moved this from Icebox to In Progress in Menlo Jan 9, 2024
@jalberto
Copy link

will be great to have linux support too, as rocm works in Linux

@freelerobot
Copy link
Contributor

Increasingly highly requested by users

@Christianb233
Copy link

Christianb233 commented Jan 13, 2024

it seems that there is no ROCm installation for GPU AMD Radeon RX6600M :-( ; so I am not able to run jan.ai on GPU :-(

@freelerobot
Copy link
Contributor

@tikikun you're tackling this issue already? How are we approaching it? Wanna do a quick share during standup

@tikikun
Copy link
Contributor Author

tikikun commented Jan 16, 2024

hi @0xSage we have built the amd image already but have no gpu to test

@Soddentrough
Copy link

Happy to volunteer if testers are needed. I can test with RDNA3 & 2.

@hiro-v hiro-v assigned hiro-v and unassigned tikikun Feb 6, 2024
@hiro-v hiro-v moved this from In Progress to Icebox in Menlo Feb 7, 2024
@freelerobot freelerobot modified the milestones: Jan Windows MVP, v0.4.7 Feb 14, 2024
@freelerobot freelerobot changed the title feat: support AMD GPUs (rocm, etc) epic: support AMD GPUs (rocm, etc) Feb 14, 2024
@freelerobot freelerobot changed the title epic: support AMD GPUs (rocm, etc) feat: support AMD GPUs (rocm, etc) Feb 14, 2024
@freelerobot freelerobot changed the title feat: support AMD GPUs (rocm, etc) epic: support AMD (vulkan, rocm, etc) Feb 15, 2024
@freelerobot freelerobot added type: epic A major feature or initiative and removed type: feature request A new feature labels Feb 15, 2024
@hiro-v hiro-v moved this from Icebox to Planned in Menlo Feb 15, 2024
@hiro-v hiro-v moved this from Planned to In Progress in Menlo Feb 16, 2024
@freelerobot
Copy link
Contributor

@hiento09 to take this on during @hiro-v leave

@jalberto
Copy link

I am happy to test in a RX 7600

@hiro-v hiro-v moved this from In Progress to In Review in Menlo Feb 19, 2024
@hiro-v hiro-v moved this from In Review to QA in Menlo Feb 19, 2024
@hiro-v
Copy link
Contributor

hiro-v commented Feb 20, 2024

Once this is merged to dev: #2056
We will let you know the build number so that you can help. Thanks @jalberto

We will likely start to experiment with rocm but it's a nice to have

@hiro-v hiro-v moved this from QA to In Progress in Menlo Feb 20, 2024
@louis-menlo
Copy link
Contributor

Experimental feature: 0.4.7

@louis-menlo louis-menlo moved this from In Progress to In Review in Menlo Feb 22, 2024
@dan-menlo dan-menlo changed the title epic: support AMD (vulkan, rocm, etc) epic: support AMD using Vulkan Feb 23, 2024
@hiro-v hiro-v moved this from In Review to QA in Menlo Feb 26, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Feb 27, 2024

Closing this and handling epic: nitro AMD ROCm GPU support janhq/nitro#323 in a separate epic

@Van-QA Van-QA closed this as completed Feb 27, 2024
@github-project-automation github-project-automation bot moved this from QA to Done in Menlo Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: important Important feature / fix type: epic A major feature or initiative
Projects
Archived in project
Development

No branches or pull requests

10 participants