Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support WSL on windows #912

Closed
Tracked by #905
tikikun opened this issue Dec 8, 2023 · 1 comment
Closed
Tracked by #905

feat: Support WSL on windows #912

tikikun opened this issue Dec 8, 2023 · 1 comment
Assignees
Labels

Comments

@tikikun
Copy link
Contributor

tikikun commented Dec 8, 2023

Epic: https://github.com/orgs/janhq/projects/5/views/16?pane=issue&itemId=46869443

Problem
Windows native having issues with inferencing, for some reasons the windows machine cannot make use properly of the core

Success Criteria
Support running nitro sub-process on WSL to enable better performance on windows

https://stackoverflow.com/questions/71603439/how-to-execute-wsl-commands-from-a-node-process

@tikikun tikikun added the type: feature request A new feature label Dec 8, 2023
@dan-menlo dan-menlo added this to the 0.4.1: Jan on Windows milestone Dec 11, 2023
@freelerobot freelerobot moved this to Triaged (Backlog) in Menlo Dec 15, 2023
@freelerobot freelerobot moved this from Icebox to Planned in Menlo Dec 29, 2023
@hiro-v hiro-v moved this from Planned to Icebox in Menlo Jan 6, 2024
@hiro-v hiro-v removed the status in Menlo Jan 8, 2024
@imtuyethan imtuyethan moved this to Planned in Menlo Jan 17, 2024
@hiro-v hiro-v moved this from Planned to Icebox in Menlo Jan 18, 2024
@hiro-v hiro-v removed the status in Menlo Jan 18, 2024
@hiro-v
Copy link
Contributor

hiro-v commented Feb 5, 2024

I think this is an advanced use case.
Refer to https://learn.microsoft.com/en-us/windows/wsl/install

You must be running Windows 10 version 2004 and higher (Build 19041 and higher) or Windows 11 to use the commands below. If you are on earlier versions please see [the manual install page](https://learn.microsoft.com/en-us/windows/wsl/install-manual).

I think running Nitro in wsl in Jan would be an anti-pattern on windows though we wee a good performance there because:

  1. User will need to install additional stuffs that can break
  2. If we really really need to run smth in Jan wsl, we might let user to install docker and use our docker images instead

@hiro-v hiro-v closed this as completed Feb 5, 2024
@github-project-automation github-project-automation bot moved this to Done in Menlo Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants