Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: doesn't gracefully stop a model #2486

Closed
kundeng opened this issue Mar 25, 2024 · 4 comments
Closed

bug: doesn't gracefully stop a model #2486

kundeng opened this issue Mar 25, 2024 · 4 comments
Assignees
Labels
P2: nice to have Nice to have feature type: bug Something isn't working
Milestone

Comments

@kundeng
Copy link

kundeng commented Mar 25, 2024

Describe the bug
Most of the time, it does not gracefully stop a model. Causing UI in a limbo state.

image

@kundeng kundeng added the type: bug Something isn't working label Mar 25, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Mar 25, 2024

hi @kundeng ,
please share with us:

  • Your OS version
  • Your spec: CPU serial, memory
  • Jan app version
  • your app.log

@Propheticus
Copy link

Propheticus commented Mar 26, 2024

Noticed the same while using the context length slider.
Each numerical change during a single slide triggers a nitro kill.
This spam can lead to a limbo state where nitro is not stopped and time-out messages flood the logs.

The workaround: kill nitro.exe from the task manager.

Win 11 pro x64, 32GB RAM, AMD Ryzen 7 7700X, AMD RX6800XT 16GB, Jan 0.4.9-343

2024-03-26T12:35:14.765Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.776Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.786Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.793Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.800Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.807Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.814Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.821Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.827Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.835Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.841Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.849Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.855Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:24.789Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.790Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.790Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.820Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.821Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.821Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.821Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.821Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.851Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.852Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.853Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.853Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.884Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout

etc, etc.
Until manually killing
2024-03-26T12:35:32.618Z [NITRO]::Debug: Nitro exited with code: 1

@Van-QA
Copy link
Contributor

Van-QA commented Mar 26, 2024

Thank you, The case of killing Nitro requested every time the context length value changed, is indeed a problem.
Even when Nitro was killed successfully (see below log), can we reduce these duplicate request? @louis-jan

2024-03-26T13:10:05.460Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T13:10:05.630Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T13:10:05.687Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T13:10:05.720Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T13:10:05.785Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T13:10:05.980Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T13:10:06.044Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T13:10:06.194Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T13:10:06.299Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T13:10:07.261Z [NITRO]::Debug: Nitro process is terminated
2024-03-26T13:10:07.261Z [NITRO]::Debug: Nitro process is terminated
2024-03-26T13:10:07.262Z [NITRO]::Debug: Nitro process is terminated
2024-03-26T13:10:07.262Z [NITRO]::Debug: Nitro process is terminated
2024-03-26T13:10:07.261Z [NITRO]::Debug: Nitro process is terminated

@louis-menlo louis-menlo moved this to Planned in Menlo Apr 2, 2024
@Van-QA Van-QA added this to the v0.4.11 milestone Apr 2, 2024
@Van-QA Van-QA added the P2: nice to have Nice to have feature label Apr 2, 2024
@louis-menlo louis-menlo moved this from Planned to In Progress in Menlo Apr 3, 2024
@louis-menlo louis-menlo moved this from In Progress to In Review in Menlo Apr 3, 2024
@louis-menlo louis-menlo moved this from In Review to In Progress in Menlo Apr 3, 2024
@louis-menlo louis-menlo moved this from In Progress to In Review in Menlo Apr 3, 2024
@louis-menlo louis-menlo moved this from In Review to QA in Menlo Apr 4, 2024
@louis-menlo louis-menlo moved this from QA to In Review in Menlo Apr 5, 2024
@louis-menlo louis-menlo moved this from In Review to In Progress in Menlo Apr 5, 2024
@louis-menlo louis-menlo moved this from In Progress to QA in Menlo Apr 5, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Apr 9, 2024

looking good on Jan v0.4.10-367 ✅

@Van-QA Van-QA closed this as completed Apr 9, 2024
@github-project-automation github-project-automation bot moved this from QA to Done in Menlo Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2: nice to have Nice to have feature type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants