Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: App.log filling hard drive #2485

Closed
Van-QA opened this issue Mar 25, 2024 · 4 comments
Closed

bug: App.log filling hard drive #2485

Van-QA opened this issue Mar 25, 2024 · 4 comments
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@Van-QA
Copy link
Contributor

Van-QA commented Mar 25, 2024

Describe the bug
Quoted from Hords

Hi, I was wondering if there's a way to disable the app.log in Windows? I run the API server and after quite a bit of use I end up filling up my hard drive due to the size of the app.log file. I can clear it, but then it ends up happening again, so it'd be nice to prevent it in the first place. Thanks!
Hi, I'm using 0.4.9 currently. testing it now and I'm up to 190GB for my log file after running it for around 4 hours, constantly querying the api server. I looked at the code, and if I read it right, it looks like this fix cleans up after 7 days? Thanks
https://discord.com/channels/1107178041848909847/1220501334508175360

Environment details

  • Operating System: Windows 10
  • Jan Version: 0.4.9
@Van-QA Van-QA added the type: bug Something isn't working label Mar 25, 2024
@Van-QA Van-QA moved this to Planned in Menlo Mar 25, 2024
@Hords
Copy link

Hords commented Mar 25, 2024

Hi, it sounds like it currently may only clean up the logs upon Jan opening, but I leave it open running the API server and so it seems to never clean up. Thanks!

@freelerobot
Copy link
Contributor

Hmm, I'm wondering what the best UX here is.

A few not so great suggestions - super open to what community says here.

  1. Cap app.logs at n lines or n mb maximum. Beyond which, we auto clear logs. This way, logs never bloat past xGB.
  2. Let users disable logs (as OP suggests)
  3. We might consider disabling the current hack of clearing every n hours, because of the previously stated reasons and because logs can bloat within just a few minutes on a bad error.

@louis-jan louis-jan moved this from Planned to In Progress in Menlo Apr 2, 2024
@louis-jan louis-jan moved this from In Progress to Planned in Menlo Apr 2, 2024
@louis-jan louis-jan moved this from Planned to In Progress in Menlo Apr 2, 2024
@louis-jan
Copy link
Contributor

@0xSage

  1. This could lead to a performance issue where the app attempts to check the size/number of lines. Let's say there are thousands of logs being written per second.
  2. Ye I would like to bring this setting to the Monitoring Extension.
  3. There is no clearing mechanism within n hours but gradual increase over time. Is it better to clean it periodically: fixed period - every 5 mins with size check (configurable)?

@louis-jan louis-jan moved this from In Progress to Planned in Menlo Apr 3, 2024
@louis-jan louis-jan moved this from Planned to In Progress in Menlo Apr 9, 2024
@Van-QA Van-QA mentioned this issue Apr 10, 2024
10 tasks
@Van-QA Van-QA added this to the v0.4.11 milestone Apr 10, 2024
@louis-jan louis-jan moved this from In Progress to In Review in Menlo Apr 10, 2024
@louis-jan louis-jan moved this from In Review to QA in Menlo Apr 10, 2024
@Van-QA
Copy link
Contributor Author

Van-QA commented Apr 12, 2024

looking good on Jan v0.4.10-371 ✅

@Van-QA Van-QA closed this as completed Apr 12, 2024
@github-project-automation github-project-automation bot moved this from QA to Done in Menlo Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

6 participants