Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to use the universal Nitro binary on MacOS target #2068

Closed
3 tasks
louis-menlo opened this issue Feb 18, 2024 · 0 comments
Closed
3 tasks

feat: update to use the universal Nitro binary on MacOS target #2068

louis-menlo opened this issue Feb 18, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@louis-menlo
Copy link
Contributor

louis-menlo commented Feb 18, 2024

Problem
So many if else for the process.arch check, let's simplify

  • Update Nitro CI to generate universal binary using lipo create
  • Update build script to pull only universal binary file
  • Remove process arch check from app's extension

Success Criteria
Removed process arch check logic from app's extension, simplify nitro load & distribute

Additional context
Add any other context or screenshots about the feature request here.

@louis-menlo louis-menlo added the type: feature request A new feature label Feb 18, 2024
@louis-menlo louis-menlo modified the milestones: v0.4.8, v0.4.7 Feb 18, 2024
@Van-QA Van-QA modified the milestones: v0.4.8, v0.4.9 Mar 1, 2024
@Van-QA Van-QA moved this to Planned in Menlo Mar 1, 2024
@Van-QA Van-QA modified the milestones: v0.4.9, v0.4.10 Mar 11, 2024
@hiento09 hiento09 moved this from Planned to Icebox in Menlo Mar 12, 2024
@Van-QA Van-QA modified the milestones: v0.4.10, v0.4.11 Mar 25, 2024
@hiento09 hiento09 moved this from Icebox to Planned in Menlo Mar 26, 2024
@hiento09 hiento09 moved this from Planned to QA in Menlo Mar 27, 2024
@hiento09 hiento09 moved this from QA to Done in Menlo Mar 27, 2024
@hiento09 hiento09 moved this from Done to In Progress in Menlo Mar 27, 2024
@hiento09 hiento09 moved this from In Progress to Done in Menlo Apr 10, 2024
@Van-QA Van-QA mentioned this issue Apr 10, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants