Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Local API Server] Revamp UIUX of model selection and indicators #1893

Closed
imtuyethan opened this issue Feb 1, 2024 · 2 comments
Closed
Assignees
Labels
P1: important Important feature / fix type: feature request A new feature
Milestone

Comments

@imtuyethan
Copy link
Contributor

imtuyethan commented Feb 1, 2024

Problems

Problem #1

Related to this issue: #1910

Currently, users are allowed to send requests to multiple models at the same time (1 active local model + multiple remote models) but the API server GUI does not reflect that:

Screenshot 2024-02-06 at 3 26 03 PM

Problem #2

Users can't see model ID to send request
Screenshot 2024-02-01 at 4 47 31 PM

Solution

Figma link: https://www.figma.com/file/ytn1nRZ17FUmJHTlhmZB9f/Jan-App?type=design&node-id=1200-116788&mode=design&t=lvE3hVidcZbbnSpg-4

1. Inform users that they can concurrently send requests to one active local model and multiple remote models

Screenshot 2024-02-06 at 4 24 51 PM

2. Separate local model & remote model & add model ID

In-scope:

  • Separate local model & remote model
  • Add model ID under model name in model selection menu -> users can click on it to copy model ID
  • Add button shortcut my models -> this will direct users to Settings / My models

Note that this component will apply to threads as well!

Screenshot 2024-02-06 at 4 41 45 PM

Out-of-scope:
In the future we will add more things to this as part of remote model UI revamp: #994

@imtuyethan imtuyethan added the type: feature request A new feature label Feb 1, 2024
@imtuyethan imtuyethan added the P1: important Important feature / fix label Feb 1, 2024
@imtuyethan imtuyethan moved this to Planned in Menlo Feb 1, 2024
@imtuyethan imtuyethan added this to the v0.4.7 milestone Feb 1, 2024
@imtuyethan imtuyethan changed the title feat: [Local API Server] Change model selection in Local API Server from model name to model ID instead feat: Add model ID under model name in model selection menu Feb 2, 2024
@imtuyethan imtuyethan changed the title feat: Add model ID under model name in model selection menu feat: Add model ID under model name & search bar in model selection menu Feb 2, 2024
@imtuyethan imtuyethan assigned imtuyethan and unassigned urmauur Feb 2, 2024
@imtuyethan imtuyethan moved this from Planned to In Progress in Menlo Feb 2, 2024
@imtuyethan imtuyethan changed the title feat: Add model ID under model name & search bar in model selection menu feat: Revamp UIUX of model calling function Feb 6, 2024
@imtuyethan imtuyethan added the needs designs Needs designs label Feb 6, 2024
@imtuyethan imtuyethan moved this from In Progress to Planned in Menlo Feb 6, 2024
@imtuyethan imtuyethan assigned urmauur and unassigned imtuyethan Feb 6, 2024
@imtuyethan imtuyethan removed the needs designs Needs designs label Feb 6, 2024
@imtuyethan imtuyethan changed the title feat: Revamp UIUX of model calling function feat: [Local API Server] Revamp UIUX of model calling function Feb 6, 2024
@urmauur urmauur moved this from Planned to In Progress in Menlo Feb 9, 2024
@urmauur urmauur moved this from In Progress to In Review in Menlo Feb 9, 2024
@urmauur urmauur moved this from In Review to QA in Menlo Feb 9, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Feb 18, 2024

@urmauur extra scroll arrow displayed when nothing to scroll in the remote tab ❌
The issue occurs only when users visit the Local tab first (with scroll down arrow) and then moving to the Remote tab

Image

@louis-menlo louis-menlo changed the title feat: [Local API Server] Revamp UIUX of model calling function feat: [Local API Server] Revamp UIUX of model selection and indicators Feb 20, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Feb 21, 2024

Tested and looking good on Jan v0.4.6-279 ✅

@Van-QA Van-QA closed this as completed Feb 21, 2024
@github-project-automation github-project-automation bot moved this from QA to Done in Menlo Feb 21, 2024
@louis-menlo louis-menlo mentioned this issue Feb 22, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: important Important feature / fix type: feature request A new feature
Projects
Archived in project
Development

No branches or pull requests

3 participants