Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update snackbar component #1639

Closed
imtuyethan opened this issue Jan 17, 2024 · 2 comments
Closed

feat: update snackbar component #1639

imtuyethan opened this issue Jan 17, 2024 · 2 comments
Assignees
@urmauur
Labels
good first issue Good for newcomers type: feature request A new feature
Milestone
v0.4.6

Comments

@imtuyethan
Copy link
Contributor

imtuyethan commented Jan 17, 2024 •
edited
Loading

Problem:

The current snackbar kinda blends in with everything else and hard to see:
Screenshot 2024-01-17 at 10 42 22 AM

Updated component

Figma link: https://www.figma.com/file/Js8MF76jMQ99fDwtnOT8pA/%E2%9A%AB%EF%B8%8F--Design-System%3A-Joi?type=design&node-id=551-8011&mode=design&t=aWOWX3L8tR0Urmzk-4

Docs

Variants

Screenshot 2024-01-17 at 12 07 01 PM

Position on screen

Screenshot 2024-01-17 at 12 04 28 PM
@imtuyethan imtuyethan added this to the v0.4.6 milestone Jan 17, 2024
@imtuyethan imtuyethan added this to Menlo Jan 17, 2024
@imtuyethan imtuyethan moved this to Planned in Menlo Jan 17, 2024
@imtuyethan imtuyethan changed the title feat: update toast component feat: update snackbar component Jan 17, 2024
@urmauur urmauur moved this from Planned to In Progress in Menlo Jan 23, 2024
@copyhold
Copy link
Contributor

hi @urmauur , are you on this ticket?

@urmauur
Copy link
Member

urmauur commented Jan 25, 2024

hi @urmauur , are you on this ticket?

Yes, i'm still working in progress on this ticket, can you take a look another ticket? 🙏🏻

@Van-QA Van-QA modified the milestones: v0.4.6, v0.4.7 Jan 29, 2024
@urmauur urmauur mentioned this issue Jan 30, 2024
Merged
3 tasks
@urmauur urmauur moved this from In Progress to In Review in Menlo Jan 30, 2024
@urmauur urmauur moved this from In Review to QA in Menlo Feb 2, 2024
@Van-QA Van-QA moved this from QA to Done in Menlo Feb 2, 2024
@Van-QA Van-QA modified the milestones: v0.4.7, v0.4.6 Feb 5, 2024
@Van-QA Van-QA closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@urmauur urmauur

Labels
good first issue Good for newcomers type: feature request A new feature
Projects
Menlo
Archived in project
Milestone
v0.4.6
Development

No branches or pull requests
4 participants
@copyhold @urmauur @Van-QA @imtuyethan