Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: decouple nitro inference engine into a library #1635

Closed
tikikun opened this issue Jan 17, 2024 · 4 comments
Closed

feat: decouple nitro inference engine into a library #1635

tikikun opened this issue Jan 17, 2024 · 4 comments
Assignees
@louis-menlo
Labels
type: feature request A new feature

Comments

@tikikun
Copy link
Contributor

tikikun commented Jan 17, 2024

Problem
Right now the way to manage nitro process is directly inside nitro extension, it's very bad for devex and also hard to keep track, debug

Success Criteria
Decoupled out into a seperate library so that user can just fix nitro library rather than entire extension
@tikikun tikikun added the type: feature request A new feature label Jan 17, 2024
@tikikun tikikun added this to Menlo Jan 17, 2024
@tikikun tikikun moved this to Planned in Menlo Jan 17, 2024
@tikikun
Copy link
Contributor Author

tikikun commented Jan 17, 2024

@louis-jan can help on prioritize this one, my suggestion is just to commit directly to nitro repo, i think no need seperate repo

InNoobWeTrust added a commit to InNoobWeTrust/jan that referenced this issue Jan 17, 2024
@InNoobWeTrust
chore(menloresearch#1635): DevX improvement
48b09a0 
- Require node engine
- Pin working node and yarn versions for use with Volta
- Add workflow to check build manually for forked repos
InNoobWeTrust added a commit to InNoobWeTrust/jan that referenced this issue Jan 17, 2024
@InNoobWeTrust
chore(menloresearch#1635): DevX improvement
ce6efe8 
- Require node engine
- Add node-gyp as required on some platforms
- Pin working node and yarn versions for use with Volta
- Add workflow to check build manually for forked repos
InNoobWeTrust added a commit to InNoobWeTrust/jan that referenced this issue Jan 17, 2024
@InNoobWeTrust
chore(menloresearch#1635): DevX improvement
9037a39 
- Require node engine
- Add node-gyp as required on some platforms
- Pin working node and yarn versions for use with Volta
- Add workflow to check build manually for forked repos
InNoobWeTrust added a commit to InNoobWeTrust/jan that referenced this issue Jan 17, 2024
@InNoobWeTrust
chore(menloresearch#1635): DevX improvement
55aec89 
- Require node engine
- Add node-gyp as required on some platforms
- Pin working node and yarn versions for use with Volta
- Add workflow to check build manually for forked repos
InNoobWeTrust added a commit to InNoobWeTrust/jan that referenced this issue Jan 17, 2024
@InNoobWeTrust
chore(menloresearch#1635): DevX improvement
713b144 
- Require node engine
- Add node-gyp as required on some platforms
- Pin working node and yarn versions for use with Volta
- Add workflow to check build manually for forked repos
- Add make target to run github action build dev locally
InNoobWeTrust added a commit to InNoobWeTrust/jan that referenced this issue Jan 17, 2024
@InNoobWeTrust
chore(menloresearch#1635): DevX improvement
dc292c9 
- Require node engine
- Add node-gyp as required on some platforms
- Pin working node and yarn versions for use with Volta
- Add workflow to check build manually for forked repos
- Add make target to run github action build dev locally
@InNoobWeTrust InNoobWeTrust mentioned this issue Jan 22, 2024
Closed
3 tasks
@louis-menlo louis-menlo moved this from Planned to In Progress in Menlo Jan 23, 2024
@louis-menlo louis-menlo moved this from In Progress to Planned in Menlo Jan 23, 2024
@louis-menlo louis-menlo moved this from Planned to In Progress in Menlo Jan 23, 2024
@InNoobWeTrust
Copy link

InNoobWeTrust commented Jan 31, 2024 •
edited
Loading

Second on this, I'm about to make a Raycast front-end UI for nitro, so I prefer to have official node wrapper to be available on NPM, then I can add it as a dependency directly in my project. 🤓

https://github.com/InNoobWeTrust/nitro-raycast

@louis-menlo louis-menlo moved this from In Progress to In Review in Menlo Jan 31, 2024
@tikikun
Copy link
Contributor Author

tikikun commented Jan 31, 2024

hi @InNoobWeTrust i appreciate the raycast front-end

tikikun added a commit to menloresearch/cortex.cpp that referenced this issue Feb 19, 2024
@tikikun
Merge pull request #367 from InNoobWeTrust/feat/1635/decouple-nitro-i…
a33e074 
…nference-engine-into-a-library

[menloresearch/jan#1635] feat: decouple nitro engine into a library
@louis-menlo
Copy link
Contributor

Thanks, @InNoobWeTrust. I'm going to close this issue, and we will open new issues if needed for bug fixes or improvements.

@github-project-automation github-project-automation bot moved this from In Review to Done in Menlo Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louis-menlo louis-menlo

Labels
type: feature request A new feature
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(WIP): decouple nitro inference engine into a library InNoobWeTrust/jan
3 participants
@tikikun @InNoobWeTrust @louis-menlo