Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: can't manually set value in Max Token input box anymore #1573

Closed
freelerobot opened this issue Jan 14, 2024 · 6 comments · Fixed by #1585
Closed

bug: can't manually set value in Max Token input box anymore #1573

freelerobot opened this issue Jan 14, 2024 · 6 comments · Fixed by #1585
Assignees
Labels
type: bug Something isn't working

Comments

@freelerobot
Copy link
Contributor

freelerobot commented Jan 14, 2024

Describe the bug
A clear and concise description of what the bug is.
Export-1705242084368

Steps to reproduce
Steps to reproduce the behavior:

  1. Go to Inference params > Max Tokens
  2. Try to type 2048
  3. It doesn't let me: it either falls to the min or max value with each keystroke
  4. Very frustrating, because hte input box UI suggests that I can type any value I want

cc @imtuyethan

Expected behavior
I should be able to adjust the values with slider or text input box.
Minimally, I should be able to type any value in Max Token.

Screenshots
If applicable, add screenshots to help explain your issue.

Environment details

  • Operating System: macos
  • Jan Version: 0.4.3-143
@freelerobot freelerobot added the type: bug Something isn't working label Jan 14, 2024
@freelerobot freelerobot changed the title bug: can't manually set value in max token input box anymore bug: can't manually set value in Max Token input box anymore Jan 14, 2024
@louis-menlo
Copy link
Contributor

This is our recent update to avoid some misleading issues, such as:

  • Users can input a very large value, which breaks the app.
  • Users can set the maximum value via model.json.
    cc @urmauur @imtuyethan

@freelerobot
Copy link
Contributor Author

This is our recent update to avoid some misleading issues, such as:

  • Users can input a very large value, which breaks the app.
  • Users can set the maximum value via model.json.
    cc @urmauur @imtuyethan

I had a feeling. UX is confusing, feels like a bug, and we'll get more bug reports. We could disable the input action or perhaps there is a better solution @imtuyethan

@dniq
Copy link

dniq commented Jan 14, 2024

Same complaint here. Can not increase Max Tokens beyond 4k.

If max tokens / cix_len can be changed in model.json file - this needs to be exposed in the UI ;)

Right now, the model goes haywire after only around 2k words:

$> wc < chat_history
203 2919 19286

Well... Maybe 3k words :D (set ctx_len to 20480 and max_tokens to the same in model.json).

@imtuyethan
Copy link
Contributor

imtuyethan commented Jan 14, 2024

Yeah this is kinda weird, i cannot clear the number @urmauur

Screen.Recording.2024-01-14.at.10.54.51.PM.mov

Suggestion: When users enter a number that exceed min or max number, we only revert to the min/max number + show tooltip when users leave the input field (by clicking outside, tap enter)

@louis-menlo
Copy link
Contributor

Yeah this is kinda weird, i cannot clear the number @urmauur

Screen.Recording.2024-01-14.at.10.54.51.PM.mov

@imtuyethan that's is minimum threshold

@imtuyethan
Copy link
Contributor

@urmauur @louis-jan
Suggestion: When users enter a number that exceeds min or max number, we only revert to the min/max number + show the tooltip when users leave the input field (by clicking outside or tapping enter)

@urmauur urmauur moved this to Icebox in Menlo Jan 15, 2024
@urmauur urmauur moved this from Icebox to In Progress in Menlo Jan 15, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Menlo Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants