Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance model/sources APIs #1869

Closed
4 of 8 tasks
louis-menlo opened this issue Jan 17, 2025 · 1 comment
Closed
4 of 8 tasks

feat: enhance model/sources APIs #1869

louis-menlo opened this issue Jan 17, 2025 · 1 comment
Assignees
Milestone

Comments

@louis-menlo
Copy link
Contributor

louis-menlo commented Jan 17, 2025

Discussion issues:

janhq/jan#4170

As discussed, there are a few missing pieces of information that we need to update the endpoint.

  • Model description (README.md?)
  • Rate limiting? Users would not want to put their huggingface token
  • Sibling file size
  • Total download (persist on adding only?)

Out of scope:

  • Likes update (persist on adding only?)
  • Modality
  • Languages (model tags?)
  • Comparison (MLU / Speed)
@github-project-automation github-project-automation bot moved this to Investigating in Menlo Jan 17, 2025
@louis-menlo louis-menlo moved this from Investigating to Scheduled in Menlo Jan 17, 2025
@louis-menlo louis-menlo moved this from Scheduled to In Progress in Menlo Jan 21, 2025
@TC117 TC117 added this to the 1.0.10 milestone Jan 21, 2025
@louis-menlo louis-menlo moved this from In Progress to Eng Review in Menlo Jan 23, 2025
@louis-menlo
Copy link
Contributor Author

Regarding the rate-limiting issue, the client application will still initialize a list of models to provide a better user experience.

So that:

  1. As soon as users open the app, they'll head straight to the Hub, where they'll immediately see a list of popular models without having to wait for the Hub to update.
  2. We avoid rate limiting because we don't allow clients to pull multiple models simultaneously.
  3. The hub should be updated gradually or implemented with a smart searching mechanism.

@github-project-automation github-project-automation bot moved this from Eng Review to QA in Menlo Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

No branches or pull requests

3 participants