Skip to content

Commit 2c51b87

Browse files
authored
make termination reason serialization match valuable (#845)
The termination reason Valuable "serialization" differs from the serde serialization. Let's make them match each other to avoid confusion. <!-- ELLIPSIS_HIDDEN --> ---- > [!IMPORTANT] > Aligns `TerminationReason` serialization in `plane/src/types/backend_state.rs` to match `valuable` and `serde` formats. > > - **Behavior**: > - Aligns `valuable::Valuable` serialization of `TerminationReason` with `serde` serialization. > - Changes string representations: `key_expired` to `keyexpired`, `startup_timeout` to `startuptimeout`, `internal_error` to `internalerror` in `TerminationReason`. > - **Files**: > - Modifies `plane/src/types/backend_state.rs` to update `Valuable` implementation for `TerminationReason`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=jamsocket%2Fplane&utm_source=github&utm_medium=referral)<sup> for 3e5fbd8. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
1 parent 4d41d0d commit 2c51b87

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

plane/src/types/backend_state.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -244,10 +244,10 @@ impl valuable::Valuable for TerminationReason {
244244
match self {
245245
TerminationReason::Swept => valuable::Value::String("swept"),
246246
TerminationReason::External => valuable::Value::String("external"),
247-
TerminationReason::KeyExpired => valuable::Value::String("key_expired"),
247+
TerminationReason::KeyExpired => valuable::Value::String("keyexpired"),
248248
TerminationReason::Lost => valuable::Value::String("lost"),
249-
TerminationReason::StartupTimeout => valuable::Value::String("startup_timeout"),
250-
TerminationReason::InternalError => valuable::Value::String("internal_error"),
249+
TerminationReason::StartupTimeout => valuable::Value::String("startuptimeout"),
250+
TerminationReason::InternalError => valuable::Value::String("internalerror"),
251251
}
252252
}
253253

0 commit comments

Comments
 (0)