Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow corrode to run against the mingw headers #146

Closed
wants to merge 13 commits into from

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Apr 29, 2017

Well at least against the string.h header. May fix #144 (fixes the current test case but @isonmad might have a test case which require additional changes?)

Marwes added 12 commits April 15, 2017 09:46
This adds the simplest possible regression test to corrode which only runs a c file through gcc as well as corrode + rustc and then runs both applications checking that their exit status is the same.
Moves all logic except a thin wrapper out of the executable Main module and into the library itself which makes it possible for the test module to run corrode directly instead of going through an external process. (Running corrode as an external process does not work at all from the tests since there is no way of knowing where the corrode executable is placed).
I think this is the failing test but it is hard to be certain due to the interleaved output
… working

Turns out that a missing return in the main function is only specified in c99.
At least the mingw standard library uses this and gcc seems to ignore it so it should't be a problem to ignore this in corrode as well
@Marwes
Copy link
Contributor Author

Marwes commented Apr 29, 2017

Depends on #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore/allow extern on function definitions
1 participant