Skip to content

Commit

Permalink
fix: remove unused rxjs peer dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesfer committed Jun 5, 2019
1 parent ea501ff commit ae0c95d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 15 deletions.
3 changes: 0 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,5 @@
"tslint-config-airbnb": "^5.7.0",
"typedoc": "^0.10.0",
"typescript": "^2.8.0"
},
"peerDependencies": {
"rxjs": "^5.5.6"
}
}
16 changes: 6 additions & 10 deletions rollup.config.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
import typescript from 'rollup-plugin-typescript';
import resolve from 'rollup-plugin-node-resolve';
import commonjs from 'rollup-plugin-commonjs';
import babel from 'rollup-plugin-babel'
import path from 'path';
import babel from 'rollup-plugin-babel';
import commonjs from 'rollup-plugin-commonjs';
import resolve from 'rollup-plugin-node-resolve';
import typescript from 'rollup-plugin-typescript';
import { dependencies } from './package.json';

const packageJson = require('./package.json');
const dependencies = [
...Object.keys(packageJson.dependencies),
...Object.keys(packageJson.peerDependencies),
];
const configurations = [
{ format: 'esm', target: 'es5' },
{ format: 'esm', target: 'es2015' },
Expand All @@ -31,7 +27,7 @@ export default configurations.map(({ target, format }) => {
typescript({ target }),
babel({ extensions: ['.ts'] }),
],
external: id => dependencies.includes(id)
external: id => id in dependencies
|| /^lodash/.test(id)
|| /^neo4j-driver/.test(id),
};
Expand Down
3 changes: 1 addition & 2 deletions src/connection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import AnyPromise from 'any-promise';
// tslint:disable-next-line import-name
import Observable from 'any-observable';
import nodeCleanup from 'node-cleanup';
import { Observable as RxObservable } from 'rxjs';
import { Dictionary, isFunction } from 'lodash';
import { AuthToken, Config, Driver, Session } from 'neo4j-driver/types/v1';
import { Transformer } from './transformer';
Expand Down Expand Up @@ -297,7 +296,7 @@ export class Connection extends Builder<Query> {
* ```
* In practice this should never happen unless you're doing some strange things.
*/
stream<R = any>(query: Query): RxObservable<Dictionary<R>> {
stream<R = any>(query: Query): Observable<Dictionary<R>> {
if (!this.open) {
throw Error('Cannot run query; connection is not open.');
}
Expand Down

0 comments on commit ae0c95d

Please sign in to comment.