Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom nodes: update to work with latest eclair #390

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

halseth
Copy link
Contributor

@halseth halseth commented Oct 26, 2020

Updates instructions for how to build custom eclair image to work with latest version.

The other Dockerfile probably also needs update. And the config option

 --on-chain-fees.max-feerate-mismatch=100000

should now be

  --on-chain-fees.feerate-tolerance.ratio-low=0.00001
  --on-chain-fees.feerate-tolerance.ratio-high=10000.0

@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #390 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          113       113           
  Lines         3245      3245           
  Branches       565       565           
=========================================
  Hits          3245      3245           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2362870...e7fe181. Read the comment docs.

@jamaljsr
Copy link
Owner

Wow! I was expecting the diff to be much larger. I'll test it out myself and merge if it's all good. Thanks so much for the PR.

@jamaljsr
Copy link
Owner

tACK 🚀

squashing to fix commit message

@jamaljsr jamaljsr merged commit c084444 into jamaljsr:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants