Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lnd): add docker container name as tlsextradomain #355

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

jamaljsr
Copy link
Owner

Closes #352

Adds the LND node's docker container name as a --tlsextradomain command line argument to support RPC connections from external docker networks.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020

Codecov Report

Merging #355 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #355   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          113       113           
  Lines         3195      3195           
  Branches       560       560           
=========================================
  Hits          3195      3195           
Impacted Files Coverage Δ
src/lib/docker/composeFile.ts 100.00% <ø> (ø)
src/utils/constants.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a538ca0...a721339. Read the comment docs.

@jamaljsr jamaljsr merged commit 5940c1b into master Jun 24, 2020
@jamaljsr jamaljsr deleted the fix/lnd-tls-domain branch June 24, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Can't connect to LND container from other container
2 participants