Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe a bug - http_build_url([ 'user' => 'abc', 'pass' => 123]); #20

Open
KTP95 opened this issue Feb 7, 2017 · 2 comments
Open

Maybe a bug - http_build_url([ 'user' => 'abc', 'pass' => 123]); #20

KTP95 opened this issue Feb 7, 2017 · 2 comments

Comments

@KTP95
Copy link

KTP95 commented Feb 7, 2017

Hello,
I'm sorry, I don't know if this is a real bug,
and if the original function (of pecl) has same output, i never work with it

Anyway:

http_build_url([ 'user' => 'abc', 'pass' => 123]);
abc:123@/

I'm not sure if @/
are correct for output...
Can something check in original pecl version ?

@peter279k
Copy link

Do you ad the test case for this related issue?

Thanks.

@LukeTowers
Copy link

Technically I believe the original PECL implementation would attempt to detect the scheme, host, and path of the current request and use those values as defaults to always return a URL with those values present, but I personally object to that behaviour and the implementation in Winter CMS returns abc:123@ for the provided input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants