Skip to content

Commit 4a733c1

Browse files
authored
Update the sigtest plugin, signature file and docs (#542)
Signed-off-by: Scott M Stark <[email protected]>
1 parent 58c8ff3 commit 4a733c1

File tree

8 files changed

+126
-75
lines changed

8 files changed

+126
-75
lines changed

dist-build/lang-model-tck-runner/pom.xml

+9-8
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,15 @@
1010
<properties>
1111
<maven.compiler.source>11</maven.compiler.source>
1212
<maven.compiler.target>11</maven.compiler.target>
13-
<cdi.tck-4-0.version>4.0.4</cdi.tck-4-0.version>
14-
<weld.version>5.0.0.SP2</weld.version>
13+
<weld.version>6.0.0.Alpha1</weld.version>
1514
</properties>
1615

1716
<dependencyManagement>
1817
<dependencies>
1918
<dependency>
2019
<groupId>jakarta.enterprise</groupId>
2120
<artifactId>cdi-tck-lang-model</artifactId>
22-
<version>${cdi.tck-4-0.version}</version>
21+
<version>${project.version}</version>
2322
</dependency>
2423
<dependency>
2524
<groupId>org.jboss.weld</groupId>
@@ -42,9 +41,11 @@
4241
<version>3.0.2.Final</version>
4342
</dependency>
4443
<dependency>
45-
<groupId>org.jboss.shrinkwrap</groupId>
46-
<artifactId>shrinkwrap-api</artifactId>
47-
<version>1.2.6</version>
44+
<groupId>org.jboss.arquillian</groupId>
45+
<artifactId>arquillian-bom</artifactId>
46+
<version>${arquillian.version}</version>
47+
<scope>import</scope>
48+
<type>pom</type>
4849
</dependency>
4950
<dependency>
5051
<groupId>org.wildfly.arquillian</groupId>
@@ -54,7 +55,7 @@
5455
<dependency>
5556
<groupId>org.jboss.arquillian.protocol</groupId>
5657
<artifactId>arquillian-protocol-servlet-jakarta</artifactId>
57-
<version>1.7.0.Alpha10</version>
58+
<version>${arquillian.version}</version>
5859
</dependency>
5960
<dependency>
6061
<groupId>log4j</groupId>
@@ -81,7 +82,7 @@
8182
<dependency>
8283
<groupId>org.jboss.arquillian.junit</groupId>
8384
<artifactId>arquillian-junit-container</artifactId>
84-
<version>1.7.0.Alpha10</version>
85+
<version>${arquillian.version}</version>
8586
<scope>test</scope>
8687
</dependency>
8788

dist-build/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@
125125
<groupId>jakarta.enterprise</groupId>
126126
<artifactId>cdi-tck-core-impl</artifactId>
127127
<version>${cdi.tck.version}</version>
128-
<classifier>sigtest-jdk11</classifier>
128+
<classifier>sigtest-jdk17</classifier>
129129
<type>sig</type>
130130
<optional>true</optional>
131131
</dependency>

doc/reference/src/main/asciidoc/sigtest.asciidoc

+35-38
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,18 @@ The sigtest plugin is availble from Maven Central using a dependency like:
1212
----
1313
...
1414
<plugin>
15-
<groupId>org.netbeans.tools</groupId>
15+
<groupId>jakarta.tck</groupId>
1616
<artifactId>sigtest-maven-plugin</artifactId>
17-
<version>1.5</version>
17+
<version>2.1</version>
1818
</plugin>
1919
----
2020

2121
The source for the sigtest plugin can be found here:
22-
https://github.com/jtulach/netbeans-apitest
22+
https://github.com/eclipse-ee4j/jakartaee-tck-tools/tree/master/tools/sigtest
2323

2424
=== Running the signature test
2525
To run the signature test, use a pom file like that found in
26-
https://github.com/eclipse-ee4j/cdi-tck/blob/master/impl/src/main/resources/sigtest-pom.xml and shown here:
26+
https://github.com/jakartaee/cdi-tck/blob/master/impl/src/main/resources/sigtest-pom.xml and shown here:
2727
[source, xml]
2828
----
2929
<?xml version="1.0"?>
@@ -34,29 +34,29 @@ https://github.com/eclipse-ee4j/cdi-tck/blob/master/impl/src/main/resources/sigt
3434
<parent>
3535
<groupId>org.eclipse.ee4j</groupId>
3636
<artifactId>project</artifactId>
37-
<version>1.0.6</version>
37+
<version>1.0.9</version>
3838
</parent>
3939
4040
<groupId>jakarta.enterprise</groupId>
4141
<artifactId>cdi-tck-sigtest</artifactId>
42-
<version>4.0</version>
42+
<version>4.1</version>
4343
<name>CDI TCK Signature Tests</name>
4444
<description>CDI TCK Signature test validation of CDI dependent API jars</description>
4545
<properties>
4646
<!-- Set the api jar artifact versions here -->
47-
<annotation.api.version>2.1.0</annotation.api.version>
47+
<annotations.api.version>3.0.0-M1</annotations.api.version>
48+
<interceptors.api.version>2.2.0-M1</interceptors.api.version>
4849
<atinject.api.version>2.0.1</atinject.api.version>
49-
<interceptor.api.version>2.1.0</interceptor.api.version>
50-
<el.api.version>5.0.0</el.api.version>
51-
<cdi.api.version>4.0.1</cdi.api.version>
50+
<el.api.version>5.0.1</el.api.version>
51+
<cdi.api.version>4.1.0.Beta1</cdi.api.version>
5252
</properties>
5353
5454
<!-- Set the api jar artifact dependencies here -->
5555
<dependencies>
5656
<dependency>
5757
<groupId>jakarta.annotation</groupId>
5858
<artifactId>jakarta.annotation-api</artifactId>
59-
<version>${annotation.api.version}</version>
59+
<version>${annotations.api.version}</version>
6060
</dependency>
6161
<dependency>
6262
<groupId>jakarta.el</groupId>
@@ -66,7 +66,7 @@ https://github.com/eclipse-ee4j/cdi-tck/blob/master/impl/src/main/resources/sigt
6666
<dependency>
6767
<groupId>jakarta.interceptor</groupId>
6868
<artifactId>jakarta.interceptor-api</artifactId>
69-
<version>${interceptor.api.version}</version>
69+
<version>${interceptors.api.version}</version>
7070
</dependency>
7171
<dependency>
7272
<groupId>jakarta.inject</groupId>
@@ -106,9 +106,9 @@ https://github.com/eclipse-ee4j/cdi-tck/blob/master/impl/src/main/resources/sigt
106106
</executions>
107107
</plugin>
108108
<plugin>
109-
<groupId>org.netbeans.tools</groupId>
109+
<groupId>jakarta.tck</groupId>
110110
<artifactId>sigtest-maven-plugin</artifactId>
111-
<version>1.5</version>
111+
<version>2.1</version>
112112
<executions>
113113
<execution>
114114
<id>sigtest</id>
@@ -119,8 +119,8 @@ https://github.com/eclipse-ee4j/cdi-tck/blob/master/impl/src/main/resources/sigt
119119
</execution>
120120
</executions>
121121
<configuration>
122-
<sigfile>cdi-api-jdk11.sig</sigfile>
123-
<packages>jakarta.decorator,jakarta.enterprise,jakarta.interceptor</packages>
122+
<sigfile>cdi-api-jdk17.sig</sigfile>
123+
<packages>jakarta.decorator,jakarta.enterprise.**,jakarta.interceptor</packages>
124124
<classes>target/classes</classes>
125125
<report>cdi-sig-report.txt</report>
126126
</configuration>
@@ -133,19 +133,15 @@ Your version should specify the dependencies on these jars as used in your compa
133133

134134
[source, console]
135135
----
136-
Scotts-iMacPro:resources starksm$ mvn -f sigtest-pom.xml verify
137-
[INFO] Scanning for projects...
138-
[INFO]
139-
[INFO] -----------------< jakarta.enterprise:cdi-tck-sigtest >-----------------
140-
[INFO] Building CDI TCK Signature Tests 4.0
141-
[INFO] --------------------------------[ jar ]---------------------------------
142-
[INFO]
136+
(base) starksm@Scotts-Mac-Studio impl % mvn -Djdk.major.version=21 -Dsignature process-resources
143137
...
144-
[INFO] --- sigtest-maven-plugin:1.5:check (sigtest) @ cdi-tck-sigtest ---
145-
[INFO] Packages: jakarta.decorator,jakarta.enterprise
138+
[INFO] --- sigtest:2.1:check (sigtest) @ cdi-tck-sigtest ---
139+
[INFO] Packages: jakarta.decorator,jakarta.enterprise.**,jakarta.interceptor
140+
Feb 16, 2024 11:42:25 PM com.sun.tdk.signaturetest.SignatureTest parseParameters
141+
INFO: SignatureTest.args: [-FileName, /Users/starksm/Dev/Jakarta/rh-cdi-tck/impl/src/main/resources/cdi-api-jdk17.sig, -static, -b, -Mode, bin, -ApiVersion, 4.1, -PackageWithoutSubpackages, jakarta.decorator, -Package, jakarta.enterprise, -PackageWithoutSubpackages, jakarta.interceptor, -BootCP, -Classpath, /Users/starksm/Dev/Jakarta/rh-cdi-tck/impl/src/main/resources/target/classes:/Users/starksm/.m2/repository/jakarta/annotation/jakarta.annotation-api/3.0.0-M1/jakarta.annotation-api-3.0.0-M1.jar:/Users/starksm/.m2/repository/jakarta/el/jakarta.el-api/5.0.1/jakarta.el-api-5.0.1.jar:/Users/starksm/.m2/repository/jakarta/interceptor/jakarta.interceptor-api/2.2.0-M1/jakarta.interceptor-api-2.2.0-M1.jar:/Users/starksm/.m2/repository/jakarta/inject/jakarta.inject-api/2.0.1/jakarta.inject-api-2.0.1.jar:/Users/starksm/.m2/repository/jakarta/enterprise/jakarta.enterprise.lang-model/4.1.0.Beta1/jakarta.enterprise.lang-model-4.1.0.Beta1.jar:/Users/starksm/.m2/repository/jakarta/enterprise/jakarta.enterprise.cdi-api/4.1.0.Beta1/jakarta.enterprise.cdi-api-4.1.0.Beta1.jar]
146142
[INFO] SignatureTest report
147-
Base version: 4.0.0-SNAPSHOT
148-
Tested version: 4.0
143+
Base version: 4.1.0-SNAPSHOT
144+
Tested version: 4.1
149145
Check mode: bin [throws removed]
150146
Constant checking: on
151147
@@ -154,13 +150,14 @@ Warning: The return type java.lang.reflect.Member can't be resolved
154150
Warning: The return type java.lang.reflect.Member can't be resolved
155151
156152
157-
[INFO] /Users/starksm/Dev/JBoss/Jakarta/cdi-tck/impl/src/main/resources/cdi-sig-report.txt: 0 failures in /Users/starksm/Dev/JBoss/Jakarta/cdi-tck/impl/src/main/resources/cdi-api-jdk11.sig
153+
[INFO] /Users/starksm/Dev/Jakarta/rh-cdi-tck/impl/src/main/resources/cdi-sig-report.txt: 0 failures in /Users/starksm/Dev/Jakarta/rh-cdi-tck/impl/src/main/resources/cdi-api-jdk17.sig
158154
[INFO] ------------------------------------------------------------------------
159155
[INFO] BUILD SUCCESS
160156
[INFO] ------------------------------------------------------------------------
161-
[INFO] Total time: 1.941 s
162-
[INFO] Finished at: 2021-12-13T11:38:06-06:00
157+
[INFO] Total time: 2.021 s
158+
[INFO] Finished at: 2024-02-16T23:42:25-06:00
163159
[INFO] ------------------------------------------------------------------------
160+
164161
----
165162

166163
You can ignore the following warnings:
@@ -169,7 +166,7 @@ You can ignore the following warnings:
169166
The important thing is that the mvn version shows "BUILD SUCCESS".
170167

171168
Another example that just specifies a compatible implementation test as the dependency to validate the API artifact signatures from the transitive dependencies is pom file like that found in
172-
https://github.com/eclipse-ee4j/cdi-tck/blob/master/impl/src/main/resources/sigtest-weld-pom.xml and shown here:
169+
https://github.com/jakartaee/cdi-tck/blob/master/impl/src/main/resources/sigtest-weld-pom.xml and shown here:
173170
[source, xml]
174171
----
175172
<?xml version="1.0"?>
@@ -180,7 +177,7 @@ https://github.com/eclipse-ee4j/cdi-tck/blob/master/impl/src/main/resources/sigt
180177
<parent>
181178
<groupId>org.eclipse.ee4j</groupId>
182179
<artifactId>project</artifactId>
183-
<version>1.0.6</version>
180+
<version>1.0.9</version>
184181
</parent>
185182
186183
<groupId>jakarta.enterprise</groupId>
@@ -190,7 +187,7 @@ https://github.com/eclipse-ee4j/cdi-tck/blob/master/impl/src/main/resources/sigt
190187
<description>CDI TCK Signature test validation of CDI dependent API jars</description>
191188
<properties>
192189
<!-- Set the Weld version to test -->
193-
<weld.version>5.0.0.CR2</weld.version>
190+
<weld.version>6.0.0.Alpha2</weld.version>
194191
</properties>
195192
196193
<!-- Set the api jar artifact dependencies here -->
@@ -224,9 +221,9 @@ https://github.com/eclipse-ee4j/cdi-tck/blob/master/impl/src/main/resources/sigt
224221
</executions>
225222
</plugin>
226223
<plugin>
227-
<groupId>org.netbeans.tools</groupId>
224+
<groupId>jakarta.tck</groupId>
228225
<artifactId>sigtest-maven-plugin</artifactId>
229-
<version>1.5</version>
226+
<version>2.1</version>
230227
<executions>
231228
<execution>
232229
<id>sigtest</id>
@@ -237,10 +234,10 @@ https://github.com/eclipse-ee4j/cdi-tck/blob/master/impl/src/main/resources/sigt
237234
</execution>
238235
</executions>
239236
<configuration>
240-
<sigfile>cdi-api-jdk11.sig</sigfile>
241-
<packages>jakarta.decorator,jakarta.enterprise,jakarta.interceptor</packages>
237+
<sigfile>cdi-api-jdk17.sig</sigfile>
238+
<packages>jakarta.decorator,jakarta.enterprise.**,jakarta.interceptor</packages>
242239
<classes>target/classes</classes>
243-
<report>cdi-sig-report.txt</report>
240+
<report>cdi-sig-report.xml</report>
244241
</configuration>
245242
</plugin>
246243
</plugins>

impl/pom.xml

+7-5
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,9 @@
145145
<classifier>audit-int</classifier>
146146
</artifact>
147147
<artifact>
148-
<file>${basedir}/src/main/resources/cdi-api-jdk11.sig</file>
148+
<file>${basedir}/src/main/resources/cdi-api-jdk17.sig</file>
149149
<type>sig</type>
150-
<classifier>sigtest-jdk11</classifier>
150+
<classifier>sigtest-jdk17</classifier>
151151
</artifact>
152152
</artifacts>
153153
</configuration>
@@ -359,8 +359,8 @@
359359
</property>
360360
</activation>
361361
<properties>
362-
<!--Default assumed JDK version, can be overriden via -Dmajor.jdk.version=X-->
363-
<jdk.major.version>11</jdk.major.version>
362+
<!--Default assumed JDK version, can be overriden via -Djdk.major.version=X-->
363+
<jdk.major.version>17</jdk.major.version>
364364
</properties>
365365
<build>
366366
<plugins>
@@ -402,13 +402,14 @@
402402
</executions>
403403
</plugin>
404404
<plugin>
405-
<groupId>org.netbeans.tools</groupId>
405+
<groupId>jakarta.tck</groupId>
406406
<artifactId>sigtest-maven-plugin</artifactId>
407407
<executions>
408408
<execution>
409409
<goals>
410410
<goal>generate</goal>
411411
</goals>
412+
<phase>process-resources</phase>
412413
</execution>
413414
</executions>
414415
<configuration>
@@ -425,6 +426,7 @@
425426
jakarta.enterprise.inject.se,
426427
jakarta.enterprise.inject.spi,
427428
jakarta.enterprise.inject.spi.configurator,
429+
jakarta.enterprise.invoke,
428430
jakarta.enterprise.util,
429431
jakarta.enterprise.lang.model,
430432
jakarta.enterprise.lang.model.declarations,

0 commit comments

Comments
 (0)