Skip to content

Commit 4089e59

Browse files
committed
Avoid using collection as bean type in ManagedBeanTypesTest
1 parent 899d79e commit 4089e59

File tree

4 files changed

+15
-115
lines changed

4 files changed

+15
-115
lines changed

impl/src/main/java/org/jboss/cdi/tck/tests/definition/bean/types/Flock.java

+2-111
Original file line numberDiff line numberDiff line change
@@ -25,119 +25,10 @@
2525
import java.util.ListIterator;
2626

2727
@Dependent
28-
public class Flock implements List<Vulture<Integer>> {
28+
public class Flock implements Gathering<Vulture<Integer>> {
2929

3030
@Override
31-
public int size() {
32-
return 0;
33-
}
34-
35-
@Override
36-
public boolean isEmpty() {
37-
return false;
38-
}
39-
40-
@Override
41-
public boolean contains(Object o) {
42-
return false;
43-
}
44-
45-
@Override
46-
public Iterator<Vulture<Integer>> iterator() {
31+
public Vulture<Integer> getType() {
4732
return null;
4833
}
49-
50-
@Override
51-
public Object[] toArray() {
52-
return null;
53-
}
54-
55-
@Override
56-
public <T> T[] toArray(T[] a) {
57-
return null;
58-
}
59-
60-
@Override
61-
public boolean add(Vulture<Integer> e) {
62-
return false;
63-
}
64-
65-
@Override
66-
public boolean remove(Object o) {
67-
return false;
68-
}
69-
70-
@Override
71-
public boolean containsAll(Collection<?> c) {
72-
return false;
73-
}
74-
75-
@Override
76-
public boolean addAll(Collection<? extends Vulture<Integer>> c) {
77-
return false;
78-
}
79-
80-
@Override
81-
public boolean addAll(int index, Collection<? extends Vulture<Integer>> c) {
82-
return false;
83-
}
84-
85-
@Override
86-
public boolean removeAll(Collection<?> c) {
87-
return false;
88-
}
89-
90-
@Override
91-
public boolean retainAll(Collection<?> c) {
92-
return false;
93-
}
94-
95-
@Override
96-
public void clear() {
97-
}
98-
99-
@Override
100-
public Vulture<Integer> get(int index) {
101-
return null;
102-
}
103-
104-
@Override
105-
public Vulture<Integer> set(int index, Vulture<Integer> element) {
106-
return null;
107-
}
108-
109-
@Override
110-
public void add(int index, Vulture<Integer> element) {
111-
}
112-
113-
@Override
114-
public Vulture<Integer> remove(int index) {
115-
return null;
116-
}
117-
118-
@Override
119-
public int indexOf(Object o) {
120-
return 0;
121-
}
122-
123-
@Override
124-
public int lastIndexOf(Object o) {
125-
return 0;
126-
}
127-
128-
@Override
129-
public ListIterator<Vulture<Integer>> listIterator() {
130-
return null;
131-
}
132-
133-
@Override
134-
public ListIterator<Vulture<Integer>> listIterator(int index) {
135-
return null;
136-
}
137-
138-
@Override
139-
public List<Vulture<Integer>> subList(int fromIndex, int toIndex) {
140-
return null;
141-
}
142-
14334
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
package org.jboss.cdi.tck.tests.definition.bean.types;
2+
3+
public interface Gathering<T> extends GroupingOfCertainType<T> {
4+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
package org.jboss.cdi.tck.tests.definition.bean.types;
2+
3+
public interface GroupingOfCertainType<T> {
4+
5+
T getType(); // just to avoid having <T> unused
6+
}

impl/src/main/java/org/jboss/cdi/tck/tests/definition/bean/types/ManagedBeanTypesTest.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,9 @@ public void testGenericHierarchyBeanTypes() {
7676
// Nested generic class inheritance
7777
Bean<Flock> flockBean = getUniqueBean(Flock.class);
7878
assertNotNull(flockBean);
79-
// Object, Flock, List<Vulture<Integer>>, Collection<Vulture<Integer>>, Iterable<Vulture<Integer>>
80-
assertTypeSetMatches(flockBean.getTypes(), Object.class, Flock.class, new TypeLiteral<List<Vulture<Integer>>>() {
81-
}.getType(), new TypeLiteral<Collection<Vulture<Integer>>>() {
82-
}.getType(), new TypeLiteral<Iterable<Vulture<Integer>>>() {
79+
// Object, Flock, Gathering<Vulture<Integer>>, GroupingOfCertainType<Vulture<Integer>>
80+
assertTypeSetMatches(flockBean.getTypes(), Object.class, Flock.class, new TypeLiteral<Gathering<Vulture<Integer>>>() {
81+
}.getType(), new TypeLiteral<GroupingOfCertainType<Vulture<Integer>>>() {
8382
}.getType());
8483
}
8584

0 commit comments

Comments
 (0)