-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Elasticsearch index prefix configurable #799
Comments
+1 would love to see this added. Our specific use case is using Elasticsearch with AZ specific ES clusters in EC2 (to avoid cross AZ replication $), while using Cross Cluster Search nodes to aggregate jaeger-query searches across N x AZ specific clusters. We do the same now with Logstash and it works great, but we use an index format like I assume the main item is making these configurable, as opposed to constants. I wonder if it's worth enforcing the two @pavolloffay would you be open to a PR for this as a first step? |
just to mention spark-dependencies job configuration and |
noting there's 3 (known) different index name patterns in use, makes me think the namespace string between the prefix and the date is the safer solution here. I'm happy to dive into a PR for at least parts of this, but would love some feedback from @pavolloffay or @yurishkuro re the proposed direction before proceeding. |
related #840 |
@yurishkuro good spot, thx. Both definitely related to eachother, do we try get it in as a single PR or split it into two...? |
my preference is to do it in one go, because as discussed in #840 it requires coordinated changes in 3 places, which if not made would leave some components unable to handle the modified index naming. |
@yurishkuro perfectly valid, thx for weighing in. I'll drop some comments on #840 - feel free to close this in favour of the PR. |
If the index prefix was configurable people could deploy {collector, query} per k8s namespace and use one elasticsearch deployment.
Related to jaegertracing/jaeger-kubernetes#85
The text was updated successfully, but these errors were encountered: