Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Elasticsearch index prefix configurable #799

Closed
pavolloffay opened this issue May 3, 2018 · 7 comments
Closed

Make Elasticsearch index prefix configurable #799

pavolloffay opened this issue May 3, 2018 · 7 comments
Assignees
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement storage/elasticsearch

Comments

@pavolloffay
Copy link
Member

If the index prefix was configurable people could deploy {collector, query} per k8s namespace and use one elasticsearch deployment.

Related to jaegertracing/jaeger-kubernetes#85

@yurishkuro yurishkuro added enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels May 15, 2018
@CpuID
Copy link

CpuID commented May 28, 2018

+1 would love to see this added.

Our specific use case is using Elasticsearch with AZ specific ES clusters in EC2 (to avoid cross AZ replication $), while using Cross Cluster Search nodes to aggregate jaeger-query searches across N x AZ specific clusters. We do the same now with Logstash and it works great, but we use an index format like purpose-az-date to namespace correctly, as opposed to what jaeger supports now of purpose-date.

I assume the main item is making these configurable, as opposed to constants. I wonder if it's worth enforcing the two jaeger-span- + jaeger-service- prefixes, and just allow an extra namespace string between the prefix and the date? This would suit both the k8s use case in this GH issue as well as our use case of AZ specific clusters, I suspect this may be flexible enough while using a single namespace config rather than two (one for spans + one for services)?

@pavolloffay would you be open to a PR for this as a first step?

@golonzovsky
Copy link

golonzovsky commented May 29, 2018

just to mention spark-dependencies job configuration and jaeger-dependencies-* indexes as well

@CpuID
Copy link

CpuID commented May 29, 2018

just to mention spark-dependencies job configuration and jaeger-dependencies-* indexes as well

noting there's 3 (known) different index name patterns in use, makes me think the namespace string between the prefix and the date is the safer solution here.

I'm happy to dive into a PR for at least parts of this, but would love some feedback from @pavolloffay or @yurishkuro re the proposed direction before proceeding.

@yurishkuro
Copy link
Member

related #840

@CpuID
Copy link

CpuID commented May 30, 2018

@yurishkuro good spot, thx. Both definitely related to eachother, do we try get it in as a single PR or split it into two...?

@yurishkuro
Copy link
Member

my preference is to do it in one go, because as discussed in #840 it requires coordinated changes in 3 places, which if not made would leave some components unable to handle the modified index naming.

@CpuID
Copy link

CpuID commented May 30, 2018

@yurishkuro perfectly valid, thx for weighing in. I'll drop some comments on #840 - feel free to close this in favour of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement storage/elasticsearch
Projects
None yet
Development

No branches or pull requests

4 participants