Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClockSkew adjuster modifies original spans when using the InMemory storage backend #787

Closed
zachidan opened this issue Apr 24, 2018 · 6 comments
Labels

Comments

@zachidan
Copy link

When using the InMemory storage backend, the ClockSkew adjuster modifies the start time and log timestamps of the original spans that are stored in the InMemory storage backaned.

As a result, once the ClockSkew adjuster was executed, there is no way to get the unadjusted spans from the InMemory storage backend. Although the InMemory storage backend should be used only for development, it is useful to get the unadjusted spans from this storage backend.

@bdelbosc
Copy link

bdelbosc commented Feb 18, 2019

Hi, I have incoherent span timestamp when using child_of relation,
in the case of asynchronous processing the parent span has no overlap with the child,
but Jaeger renders the trace like if the child span was in the middle of the parent span (instead of being after).
I am using the in-memory version of Jaeger, is this the same problem due to the ClockSkew adjuster or is this because my relation should be defined as followsFrom ?

@yurishkuro
Copy link
Member

For async you should be using follows-from reference.

@bdelbosc
Copy link

Thanks for your reply, I will try to figure out how to do that with opencensus.

@yurishkuro
Copy link
Member

oh, I don't think you can.

@bdelbosc
Copy link

bdelbosc commented Feb 19, 2019

Apparently, I found a way to use follows-from reference with opencensus-java:
census-instrumentation/opencensus-java#1760 (comment)

@jkowall
Copy link
Contributor

jkowall commented Jun 5, 2024

This is handled in Otel now, so closing it out.

@jkowall jkowall closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants