Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-bindata-assetsf missing from Hotrod example #751

Closed
cory-klein opened this issue Mar 22, 2018 · 2 comments
Closed

go-bindata-assetsf missing from Hotrod example #751

cory-klein opened this issue Mar 22, 2018 · 2 comments

Comments

@cory-klein
Copy link
Contributor

cory-klein commented Mar 22, 2018

Following the given hotrod instructions here.

When running this step:

cd examples/hotrod
go run ./main.go all

I get the following error message:

$ go run ./main.go all
services/frontend/bindata_assetfs.go:9:2: cannot find package "github.com/elazarl/go-bindata-assetfs" in any of:
	/Users/coryklein/go/src/github.com/jaegertracing/jaeger/vendor/github.com/elazarl/go-bindata-assetfs (vendor tree)
	/usr/local/Cellar/go/1.10/libexec/src/github.com/elazarl/go-bindata-assetfs (from $GOROOT)
	/Users/coryklein/go/src/github.com/elazarl/go-bindata-assetfs (from $GOPATH)

I was able to resolve with cd ../.. && go get ./..., but that wasn't mentioned in the documentation. Is the documentation wrong, or is there some configuration missing from the example itself?

@pavolloffay
Copy link
Member

run make build-examples. It will fetch bindata via go get

True is that we don't add bindata to glide. We should consider it.

@cory-klein
Copy link
Contributor Author

cory-klein commented Mar 22, 2018

Created the PR for your convenience. Feel free to merge or close as you see fit.

PR#752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants