Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package static assets inside the query-service binary #609

Closed
yurishkuro opened this issue Dec 21, 2017 · 2 comments
Closed

Package static assets inside the query-service binary #609

yurishkuro opened this issue Dec 21, 2017 · 2 comments
Assignees
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

Currently we copy static assets directory to the docker image separately and point the query service to it using cli switch.

Some people swear by https://github.com/jteeuwen/go-bindata or its extension https://github.com/elazarl/go-bindata-assetfs.

This will be especially useful if we support non-Docker packaging (#426).

@yurishkuro yurishkuro added enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement beginner_task labels Dec 21, 2017
@pavolloffay
Copy link
Member

Here is a nice list of alternatives https://github.com/shurcooL/vfsgen#alternatives

I plan to use one for hotrod to fix #694 (comment)

@eundoosong
Copy link
Contributor

eundoosong commented Mar 22, 2018

This feature looks interesting and I found hotrod already merged with go-bindata-assetfs (#702)
I'll have a look for contribution. (would be good start of contribution as a beginner in jaeger backend :) )

Update: I'm working on this issue( WIP branch : https://github.com/eundoosong/jaeger/blob/aa0576d67223c07ba6008ba3563ed30dab3aa333/cmd/query/app/static_handler.go )
'll PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

No branches or pull requests

3 participants