Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard to operation name on sampling.strategies-file #1387

Open
jdamasceno opened this issue Feb 27, 2019 · 1 comment
Open

Wildcard to operation name on sampling.strategies-file #1387

jdamasceno opened this issue Feb 27, 2019 · 1 comment

Comments

@jdamasceno
Copy link

Proposal - what do you suggest to solve the problem or improve the existing situation?

Hi, i would like to request a feature to use a wildcard on the operation name in sampling.strategies-file of the jaeger collector.

Today:

    "operation_strategies": [
        {
          "operation": "op1",
          "type": "probabilistic",
          "param": 0.2
        },
        {
          "operation": "op2",
          "type": "probabilistic",
          "param": 0.2
        }
      ]

After the feature:

    "operation_strategies": [
        {
          "operation": "op*",
          "type": "probabilistic",
          "param": 0.2
        }
      ]
@yurishkuro
Copy link
Member

If you want a default, the config has a separate section for it. However, understanding a wildcard requires significant changes in how clients are implemented, across all languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants