From cbef0132c8a9455ce93df90d6bd6e5041c4e48b8 Mon Sep 17 00:00:00 2001 From: Yuri Shkuro Date: Sun, 29 May 2022 15:59:23 -0400 Subject: [PATCH] Apply suggestions from code review Signed-off-by: Yuri Shkuro Co-authored-by: Albert <26584478+albertteoh@users.noreply.github.com> --- cmd/collector/app/handler/otlp_receiver.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/collector/app/handler/otlp_receiver.go b/cmd/collector/app/handler/otlp_receiver.go index 3bdf41a9d8e..97b4faf954d 100644 --- a/cmd/collector/app/handler/otlp_receiver.go +++ b/cmd/collector/app/handler/otlp_receiver.go @@ -58,7 +58,7 @@ func StartOtelReceiver(options OtelReceiverOptions, logger *zap.Logger, spanProc otlpConsumer := newConsumerDelegate(logger, spanProcessor) // the following two constructors never return errors given non-nil arguments, so we ignore errors - nextConsumer, _ := consumer.NewTraces(consumer.ConsumeTracesFunc(otlpConsumer.consume)) + nextConsumer, _ := consumer.NewTraces(otlpConsumer.consume) otlpReceiver, _ := otlpFactory.CreateTracesReceiver( context.Background(), otlpReceiverSettings, @@ -90,7 +90,7 @@ type consumerDelegate struct { protoFromTraces func(td ptrace.Traces) ([]*model.Batch, error) } -func (c *consumerDelegate) consume(ctx context.Context, ld ptrace.Traces) error { +func (c *consumerDelegate) consume(_ context.Context, ld ptrace.Traces) error { batches, err := c.protoFromTraces(ld) if err != nil { return err