From 980dc31ae1df490e9e20d61ba0ce16eab1f7b1c5 Mon Sep 17 00:00:00 2001 From: Long FlyBridge Date: Thu, 9 Jan 2025 11:22:03 +0800 Subject: [PATCH] chore: fix some struct names in comment (#6513) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Which problem is this PR solving? - ## Description of the changes fix some struct names in comment resubmit for https://github.com/jaegertracing/jaeger/pull/6253 and https://github.com/jaegertracing/jaeger/pull/6509 ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: longxiangqiao --- cmd/collector/app/sanitizer/service_name_sanitizer.go | 2 +- pkg/es/client/index_client.go | 2 +- storage_v2/tracestore/writer.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/collector/app/sanitizer/service_name_sanitizer.go b/cmd/collector/app/sanitizer/service_name_sanitizer.go index dcffe0c6215..3c7950e3c3d 100644 --- a/cmd/collector/app/sanitizer/service_name_sanitizer.go +++ b/cmd/collector/app/sanitizer/service_name_sanitizer.go @@ -15,7 +15,7 @@ func NewServiceNameSanitizer(c cache.Cache) SanitizeSpan { return sanitizer.Sanitize } -// ServiceNameSanitizer sanitizes the service names in span annotations given a source of truth alias to service cache. +// serviceNameSanitizer sanitizes the service names in span annotations given a source of truth alias to service cache. type serviceNameSanitizer struct { cache cache.Cache } diff --git a/pkg/es/client/index_client.go b/pkg/es/client/index_client.go index 624f1ed34b6..522bb45b5a4 100644 --- a/pkg/es/client/index_client.go +++ b/pkg/es/client/index_client.go @@ -29,7 +29,7 @@ type Alias struct { Index string // Alias name. Name string - // IsWritedIndex option + // IsWriteIndex option IsWriteIndex bool } diff --git a/storage_v2/tracestore/writer.go b/storage_v2/tracestore/writer.go index e46df9e0e13..25ee4fc04d5 100644 --- a/storage_v2/tracestore/writer.go +++ b/storage_v2/tracestore/writer.go @@ -11,7 +11,7 @@ import ( // Writer writes spans to storage. type Writer interface { - // WriteTrace writes a batch of spans to storage. Idempotent. + // WriteTraces writes a batch of spans to storage. Idempotent. // Implementations are not required to support atomic transactions, // so if any of the spans fail to be written an error is returned. // Compatible with OTLP Exporter API.