From 9e7f00644b6497260e236c0eff05ecbae96390ff Mon Sep 17 00:00:00 2001 From: Ansh Goyal Date: Tue, 22 Aug 2023 20:57:02 +0530 Subject: [PATCH 1/2] Upgrade react-icons Signed-off-by: Ansh Goyal --- packages/jaeger-ui/package.json | 3 +-- .../Graph/DdgNodeContent/index.tsx | 6 ++--- .../Header/ChevronDown.test.js | 2 +- .../DeepDependencies/Header/ChevronDown.tsx | 2 +- .../Header/HopsSelector/Selector.tsx | 8 +++--- .../DeepDependencies/Header/index.test.js | 3 +-- .../DeepDependencies/Header/index.tsx | 3 +-- .../DeepDependencies/SidePanel/index.tsx | 3 +-- .../components/SearchTracePage/SearchForm.jsx | 2 +- .../SearchResults/ResultItem.tsx | 2 +- .../TraceDiff/TraceDiffHeader/TraceHeader.tsx | 2 +- .../TracePageHeader/TracePageHeader.tsx | 10 +++---- .../TracePageHeader/TracePageSearchBar.tsx | 5 ++-- .../TraceTimelineViewer/SpanBarRow.tsx | 14 +++++----- .../SpanDetail/AccordianKeyValues.tsx | 5 ++-- .../SpanDetail/AccordianLogs.tsx | 5 ++-- .../SpanDetail/AccordianReferences.tsx | 5 ++-- .../SpanDetail/AccordianText.tsx | 5 ++-- .../SpanTreeOffset.test.js | 12 ++++----- .../TraceTimelineViewer/SpanTreeOffset.tsx | 6 ++--- .../common/DetailsCard/DetailTable.test.js | 2 +- .../common/DetailsCard/DetailTable.tsx | 2 +- .../DetailsCard/DetailTableDropdown.tsx | 5 ++-- .../components/common/DetailsCard/index.tsx | 2 +- .../components/common/FilteredList/index.tsx | 2 +- .../src/components/common/NameSelector.tsx | 2 +- .../src/components/common/NewWindowIcon.tsx | 4 +-- yarn.lock | 26 +++---------------- 28 files changed, 60 insertions(+), 88 deletions(-) diff --git a/packages/jaeger-ui/package.json b/packages/jaeger-ui/package.json index 1b36bf85fd..59d3139aee 100644 --- a/packages/jaeger-ui/package.json +++ b/packages/jaeger-ui/package.json @@ -49,7 +49,6 @@ "@types/lodash": "^4.14.123", "@types/object-hash": "^3.0.2", "@types/react-helmet": "^6.1.5", - "@types/react-icons": "2.2.7", "@types/react-redux": "^5.0.6", "@types/react-router-dom": "^4.3.1", "@types/react-virtualized-select": "^3.0.7", @@ -83,7 +82,7 @@ "react-dom": "^18.2.0", "react-ga": "^3.3.1", "react-helmet": "^6.1.0", - "react-icons": "2.2.7", + "react-icons": "^4.10.1", "react-is": "^18.2.0", "react-redux": "^5.0.6", "react-router-dom": "4.3.1", diff --git a/packages/jaeger-ui/src/components/DeepDependencies/Graph/DdgNodeContent/index.tsx b/packages/jaeger-ui/src/components/DeepDependencies/Graph/DdgNodeContent/index.tsx index 369e26eeba..19f4c51bc0 100644 --- a/packages/jaeger-ui/src/components/DeepDependencies/Graph/DdgNodeContent/index.tsx +++ b/packages/jaeger-ui/src/components/DeepDependencies/Graph/DdgNodeContent/index.tsx @@ -16,8 +16,8 @@ import * as React from 'react'; import { Checkbox, Popover } from 'antd'; import cx from 'classnames'; import { TLayoutVertex } from '@jaegertracing/plexus/lib/types'; -import IoAndroidLocate from 'react-icons/lib/io/android-locate'; -import MdVisibilityOff from 'react-icons/lib/md/visibility-off'; +import { MdVisibilityOff } from 'react-icons/md'; +import { IoLocate } from 'react-icons/io5'; import { connect } from 'react-redux'; import { bindActionCreators, Dispatch } from 'redux'; @@ -326,7 +326,7 @@ export class UnconnectedDdgNodeContent extends React.PureComponent - + Focus paths through this node diff --git a/packages/jaeger-ui/src/components/DeepDependencies/Header/ChevronDown.test.js b/packages/jaeger-ui/src/components/DeepDependencies/Header/ChevronDown.test.js index 8bf7e4721a..19880f178c 100644 --- a/packages/jaeger-ui/src/components/DeepDependencies/Header/ChevronDown.test.js +++ b/packages/jaeger-ui/src/components/DeepDependencies/Header/ChevronDown.test.js @@ -14,7 +14,7 @@ import React from 'react'; import { shallow } from 'enzyme'; -import IoChevronDown from 'react-icons/lib/io/chevron-down'; +import { IoChevronDown } from 'react-icons/io5'; import ChevronDown from './ChevronDown'; diff --git a/packages/jaeger-ui/src/components/DeepDependencies/Header/ChevronDown.tsx b/packages/jaeger-ui/src/components/DeepDependencies/Header/ChevronDown.tsx index 4cbe5c6021..88e75d9c98 100644 --- a/packages/jaeger-ui/src/components/DeepDependencies/Header/ChevronDown.tsx +++ b/packages/jaeger-ui/src/components/DeepDependencies/Header/ChevronDown.tsx @@ -13,7 +13,7 @@ // limitations under the License. import * as React from 'react'; -import IoChevronDown from 'react-icons/lib/io/chevron-down'; +import { IoChevronDown } from 'react-icons/io5'; import './ChevronDown.css'; diff --git a/packages/jaeger-ui/src/components/DeepDependencies/Header/HopsSelector/Selector.tsx b/packages/jaeger-ui/src/components/DeepDependencies/Header/HopsSelector/Selector.tsx index df89226489..e88df0b70b 100644 --- a/packages/jaeger-ui/src/components/DeepDependencies/Header/HopsSelector/Selector.tsx +++ b/packages/jaeger-ui/src/components/DeepDependencies/Header/HopsSelector/Selector.tsx @@ -14,8 +14,8 @@ import React, { PureComponent } from 'react'; import { Popover } from 'antd'; -import SortAmountAsc from 'react-icons/lib/fa/sort-amount-asc.js'; -import IoChevronRight from 'react-icons/lib/io/chevron-right'; +import { ImSortAmountAsc } from 'react-icons/im'; +import { FaChevronRight } from 'react-icons/fa'; import ChevronDown from '../ChevronDown'; import { trackHopChange } from '../../index.track'; @@ -48,7 +48,7 @@ export default class Selector extends PureComponent { const { direction } = this.props; return ( - {Boolean(showChevron) && } + {Boolean(showChevron) && } )} diff --git a/packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageSearchBar.tsx b/packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageSearchBar.tsx index 9c256792b3..309ac4eea3 100644 --- a/packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageSearchBar.tsx +++ b/packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageSearchBar.tsx @@ -15,9 +15,8 @@ import * as React from 'react'; import { Button, Input, Tooltip } from 'antd'; import cx from 'classnames'; -import IoAndroidLocate from 'react-icons/lib/io/android-locate'; +import { IoLocate, IoHelp } from 'react-icons/io5'; -import IoHelp from 'react-icons/lib/io/help'; import * as markers from './TracePageSearchBar.markers'; import { trackFilter } from '../index.track'; import UiFindInput from '../../common/UiFindInput'; @@ -106,7 +105,7 @@ export function TracePageSearchBarFn(props: TracePageSearchBarProps & { forwarde htmlType="button" onClick={focusUiFindMatches} > - + , -