Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for plexus package #340

Open
5 tasks
tiffon opened this issue Mar 8, 2019 · 7 comments
Open
5 tasks

Unit tests for plexus package #340

tiffon opened this issue Mar 8, 2019 · 7 comments
Labels
help wanted plexus Specific to packages/plexus

Comments

@tiffon
Copy link
Member

tiffon commented Mar 8, 2019

Can be broken down into sub-tickets:

  • Build up and running for tests
  • Layout
    • Sub-parts TODO
  • Directed graph
    • Sub-parts TODO

Make sure code coverage is sent to codecov.io, too.

@tiffon tiffon added help wanted plexus Specific to packages/plexus labels Mar 8, 2019
@mahdikhashan
Copy link

is it still a valid issue to work on?
cc: @yurishkuro

@yurishkuro
Copy link
Member

Yes

@mahdikhashan
Copy link

ok, i would go with vitest, however the bundler is webpack for this package and for ui is vite. do you have any preference @yurishkuro ?

@yurishkuro
Copy link
Member

It's not a contradiction to use both vite and webpack. I do not recommend changing this just to add tests.

@mahdikhashan
Copy link

mahdikhashan commented Jan 7, 2025

ok, if I got your correctly, I'm keeping webpack as it is - no change to bundler- , as i meant in my earlier comment. for testing package - i'll use vitest.

tasks:

  1. setup vitest
  2. open pr, communicate about test suites and cases for components (will keep it a wip pr and ask for your feedback for the direction) - i'm assuming i may have unit tests - not integrations or e2e - i'm not sure i need to mock anything, but will communicate it.

please react to this comment in case we are on the same page @yurishkuro

@mahdikhashan
Copy link

i have attached a draft pr by mentioning this issue, lets keep our conversation there.

@mahdikhashan
Copy link

i have opened the setup pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted plexus Specific to packages/plexus
Projects
None yet
Development

No branches or pull requests

3 participants