Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show playlist name in Now Playing #4

Closed
jaedb opened this issue Jan 2, 2017 · 8 comments
Closed

Show playlist name in Now Playing #4

jaedb opened this issue Jan 2, 2017 · 8 comments

Comments

@jaedb
Copy link
Owner

jaedb commented Jan 2, 2017

From @antons- on December 21, 2016 10:35

First of all, love the work you have done on this amazing frontend! Thanks heaps!

In our office, person A will add a playlist to the Now Playing queue. Person B, C and D will often ask 'what playlist is that'? This happens every day lol.

It would be cool if Spotmop showed the current playlist name (if any) in the Now Playing area and linked off to it so others in the office can discover the playlist if they like it.

Copied from original issue: jaedb/spotmop#164

@jaedb
Copy link
Owner Author

jaedb commented Jan 2, 2017

From @hcoohb on December 21, 2016 11:5

Hi, I like that idea, that would be an awesome feature!

On Dec 21, 2016 8:35 PM, "Anton Smith" [email protected] wrote:

First of all, love the work you have done on this amazing frontend! Thanks
heaps!

In our office, person A will add a playlist to the Now Playing queue.
Person B, C and D will often ask 'what playlist is that'? This happens
every day lol.

It would be cool if Spotmop showed the current playlist name (if any) in
the Now Playing area and linked off to it so others in the office can
discover the playlist if they like it.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
jaedb/spotmop#164, or mute the thread
https://github.com/notifications/unsubscribe-auth/AMX-p6DVtCZ14Rxksgb6hRdG7bm5e3dUks5rKQDjgaJpZM4LSzNR
.

@jaedb
Copy link
Owner Author

jaedb commented Jan 2, 2017

This is a neat idea, and Spotify manages to pull this off in their application. When building this from scratch (as we would need to do) there are a few tricky bits to consider. For example: what if we add other tracks to the queue, at what point have we 'finished' playing the playlist?

@antons-
Copy link

antons- commented Jan 2, 2017

I would use the Spotify web client as an example for this functionality:

2

The queue is divided into different tiers:

The playlist is finished once all its tracks have been played. At that point, the queue will continue with any remaining tracks (or other playlists) until the queue is empty.

I suspect that the playlist information (if any) will need to be stored alongside the queued track.

Other thoughts -

  • How would reordering the queue work? Will Iris still show the associated playlist in some way?
  • Instead of showing the queue as a tier like the Spotify web client - should we instead show that a queued track is part of a playlist by displaying some kind of icon (where the red box is)? The icon will have the playlist title as a tooltip and simply link off to it. This would make reordering the playlist simpler as well.
    3

@jaedb jaedb self-assigned this Jan 3, 2017
@jaedb
Copy link
Owner Author

jaedb commented Feb 9, 2017

I think the most achievable option is the have a new column Origin that specifies where the tltrack came from. This way we don't reinvent the mopidy tracklist engine.

@jaedb
Copy link
Owner Author

jaedb commented Feb 14, 2017

Some solid progress has been made by creating a queue metadata store that holds both the user who added the track (#16), and where the track came from (if applicable).

You can see this working on the queue-helper branch (latest commit 4ccc564). It'd be great if people could give it a spin and let me know if they encounter any bugs.

@fekete-robert
Copy link

Hi @jaedb , are there any nightly builds for testing it (available via pip/apt), or only the development version you describe in the Readme.md?

@jaedb
Copy link
Owner Author

jaedb commented Feb 15, 2017

Not currently - the only way to test builds is to install via the development methods from the wiki. It may be more involved to setup, but gets you in a position to be able to tweak and test code directly.

@jaedb
Copy link
Owner Author

jaedb commented Feb 15, 2017

Original issue resolved in 2.12.0 58037c8

@jaedb jaedb closed this as completed Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants