Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the JSON graph data structure #85

Open
jabrena opened this issue Jun 25, 2023 · 9 comments
Open

Redesign the JSON graph data structure #85

jabrena opened this issue Jun 25, 2023 · 9 comments

Comments

@jabrena
Copy link
Owner

jabrena commented Jun 25, 2023

Currently, the Graph based on D3.js only use information about Edge to recreate Nodes.
Besides, few Edges are false Edges because target is null.
With a better Graph representation should be better.

===

public record GraphData(List<BeanNode> nodes, List<Edge> edges) {}
@jabrena jabrena added this to the 0.2.0-SNAPSHOT milestone Jun 25, 2023
@jabrena jabrena changed the title Redesign the graph data structure Redesign the JSON graph data structure Jun 28, 2023
@jabrena

This comment was marked as resolved.

@jabrena
Copy link
Owner Author

jabrena commented Jun 29, 2023

Fix the tests tomorrow

@jabrena
Copy link
Owner Author

jabrena commented Jun 30, 2023

I’m the edges, it is not necessary to maintain the package & dependency

@jabrena
Copy link
Owner Author

jabrena commented Jun 30, 2023

curl -v "http://localhost:8080/actuator/userbeans/graph2?dependency=UNKNOWN" | json_pp

@jabrena

This comment was marked as resolved.

@jabrena
Copy link
Owner Author

jabrena commented Jul 16, 2023

#138

@jabrena
Copy link
Owner Author

jabrena commented Jul 16, 2023

#111

@jabrena
Copy link
Owner Author

jabrena commented Jul 16, 2023

curl -v "http://localhost:8080/actuator/userbeans/graph?dependency=micrometer-observation-1.11.0.jar" | json_pp

Improve nodes:

{
   "edges" : [
      {
         "source" : {
            "beanName" : "SimpleObservationRegistry",
            "beanPackage" : "io.micrometer.observation",
            "dependency" : "micrometer-observation-1.11.0.jar"
         },
         "target" : {
            "beanName" : "ObservationAutoConfiguration",
            "beanPackage" : "UNKNOWN",
            "dependency" : "UNKNOWN"
         }
      }
   ],
   "nodes" : [
      {
         "beanName" : "SimpleObservationRegistry",
         "beanPackage" : "io.micrometer.observation",
         "dependency" : "micrometer-observation-1.11.0.jar"
      }
   ]
}

@jabrena jabrena added priority and removed priority labels Jul 16, 2023
@jabrena
Copy link
Owner Author

jabrena commented Jul 19, 2023

I need to find a good test strategy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant