Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for parameterized github api url #57

Merged

Conversation

furlongm
Copy link
Contributor

fixes #55

@jcfr
Copy link
Collaborator

jcfr commented Apr 11, 2019

Thanks for the contribution 👍

Would it be possible to have a look at the following error:

./github_release.py:188: [E999] SyntaxError: invalid syntax
    global _github_api_url = github_api_url
                           ^

I suggest to do this instead:

global _github_api_url
_github_api_url = github_api_url

@furlongm furlongm force-pushed the feature/parameterized-github-api-url branch 2 times, most recently from b67ceaa to 1f714af Compare April 11, 2019 17:55
@furlongm furlongm force-pushed the feature/parameterized-github-api-url branch from 1f714af to 7d04474 Compare April 11, 2019 18:10
@furlongm
Copy link
Contributor Author

Apologies, fixed that error. Travis checks seem to be failing now due to TOKEN not existing. Not sure if my change introduced that error?

@jcfr
Copy link
Collaborator

jcfr commented Apr 11, 2019

Thanks for updating the PR.

Not sure if my change introduced that error

The failure are independent of your changes, the issue is that the GITHUB_TOKEN is not available for PR submitted from fork. I will fix the test so that they are skipped

@jcfr jcfr merged commit 5421d1a into scikit-build:master Apr 11, 2019
@jcfr
Copy link
Collaborator

jcfr commented Apr 11, 2019

As soon as the CI is done, I will release a new version of the package on PyPi.

@jcfr
Copy link
Collaborator

jcfr commented Apr 11, 2019

jcfr added a commit that referenced this pull request Mar 29, 2020
* fix-api-usage:
  Add github_api_url/set_github_api_url
  CHANGES: Reference changes introduced in pull-request #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for non public github URL
2 participants