Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete enhancement #51

Merged
merged 5 commits into from
Mar 28, 2020
Merged

Conversation

Flamefire
Copy link
Contributor

Fixes #50

You can now delete releases based on type (all, draft, prerelease or release) and on age (-older-than HOURS)

Also updates the docu (was missing verbose and dry-run) and fixes a performance bug: Releases were loaded in delete and again before deleting a single release causing a unnecessary slow down

@Flamefire
Copy link
Contributor Author

@jcfr The failures are due to the missing token. Anything I could do to make it pass? Otherwise can this be merged?

@jcfr jcfr merged commit 009585f into scikit-build:master Mar 28, 2020
@Flamefire Flamefire deleted the delete_enhancement branch March 28, 2020 22:18
@jcfr
Copy link
Collaborator

jcfr commented Mar 29, 2020

For future reference, the integration of this PR has been voided by force pushing master to integrate the following branches:

  • created branch `support-delete-given-release-type' with two commits:
    • 7e73cf9: gh_release: Speed-up release deletion
    • fc7e693 gh_release: Support deleting releases based on release type
  • created branch support-delete-based-on-age with one commit:
    • ea6b00d Add older-than switch to limit deletion by age

Finally, the CHANGES document has also been updated to reference the feature addition and performance improvement.

@Flamefire Thanks again for your patience and for your contributions 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete (old) draft releases
2 participants