Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests when no VERSION file exists #44

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Fix tests when no VERSION file exists #44

merged 1 commit into from
Jan 31, 2018

Conversation

jcfr
Copy link
Collaborator

@jcfr jcfr commented Jan 31, 2018

No description provided.

@jcfr
Copy link
Collaborator Author

jcfr commented Jan 31, 2018

@lucasbrunialti Thanks for improving the tests. Our of curiosity, which workflow did you follow to produce the error fixed by this commit ?

@lucasbrunialti
Copy link
Contributor

I followed the steps in here (https://github.com/j0057/github-release#testing):

To execute the integration tests locally, and make sure your awesome contribution is working as expected, you will have to:

  • create a test repository with at least one commit (e.g yourname/github-release-test)
  • set environment variable INTEGRATION_TEST_REPO_NAME=yourname/github-release-test
  • execute python setup.py test

@lucasbrunialti
Copy link
Contributor

Created this repo with a initial commit: https://github.com/lucasbrunialti/github-release-test

@jcfr
Copy link
Collaborator Author

jcfr commented Jan 31, 2018

Makes sense. Thanks for the rapid feedback.

@jcfr jcfr merged commit 50af996 into master Jan 31, 2018
@jcfr jcfr deleted the improve-tests branch January 31, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants