rework nested boundaries #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 87e1ecc)
DeepCode Report (#7bef12)DeepCode analyzed this pull request. |
izar
approved these changes
Nov 7, 2019
|
want me to rebase out the commit from @jdcallet I cherry picked in here? (to resolve the conflicts) |
|
Yup, looks good from my side, could you please test and confirm? |
|
yep, just tested latest |
|
Great, pushing to Pypi, thanks a lot to you and @jdcallet ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #54 @jdcallet reports an issue with nested boundaries: all boundaries are being nested in the order they're defined. This PR builds on their fix taking the approach described here.
I've tested this on a more complicated threat model example and the boundaries are rendering as expected in the nested/non-nested case (the PNGs are huge so not attaching here, but one can test for themselves via
./sd.py --debug --dfd | dot -Tpng -o dfdboth onmasterand on this branch).