From cdf03d641a1407099a4b2f235f9075419dd8d59e Mon Sep 17 00:00:00 2001 From: Ivan Valdes Date: Sun, 5 May 2024 20:11:14 -0700 Subject: [PATCH] github/workflows: remove golangci-lint-action step from static-analysis The golangci-lint-action step runs only on the repository's top-level directory. Then, make verify reruns it on the same directory, which is redundant. However, to keep make verify target working, golangci-lint needs to be installed locally. Signed-off-by: Ivan Valdes --- .github/workflows/static-analysis.yaml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/static-analysis.yaml b/.github/workflows/static-analysis.yaml index 0611fd3e06f..74985d96929 100644 --- a/.github/workflows/static-analysis.yaml +++ b/.github/workflows/static-analysis.yaml @@ -12,13 +12,8 @@ jobs: - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0 with: go-version: ${{ steps.goversion.outputs.goversion }} - - id: golangci_lint_version - run: echo "golangci_lint_version=$(cd tools/mod && go list -m -f {{.Version}} github.com/golangci/golangci-lint)" >> "$GITHUB_OUTPUT" - - name: golangci-lint - uses: golangci/golangci-lint-action@9d1e0624a798bb64f6c3cea93db47765312263dc # v5.1.0 - with: - version: ${{ steps.golangci_lint_version.outputs.golangci_lint_version }} - args: --config tools/.golangci.yaml + - run: | + go install github.com/golangci/golangci-lint/cmd/golangci-lint@"$(cd tools/mod && go list -m -f {{.Version}} github.com/golangci/golangci-lint)" - name: protoc uses: arduino/setup-protoc@149f6c87b92550901b26acd1632e11c3662e381f # v1.3.0 with: