-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Playlist continuation is broken #2694
Comments
Original comment by @foghawk at #2782 (comment) -- Describe the bug Playlist pages show 200 videos per page, but changing the "page" parameter adjusts the offset into the playlist by only 100 videos per page. Most videos in long playlists therefore appear twice, making the pagination difficult to use. In addition, it appears that
This can result in videos being repeated within individual pages (and seems like it would remain an issue, albeit between rather than within pages, even if the page length discrepancy were fixed). Steps to Reproduce
Expected behavior: pages are disjoint segments of the playlist, and each video is displayed once. Actual behavior: the first block of videos on the second page is the same as the second block of videos on the first page (and this holds for each successive pair of pages), and some videos may be displayed twice on the same page. Here is another example of an affected playlist. One video, number 18, has been copyright-struck and taken down; one video ("Ninja Movies") is displayed twice on the first page. Additional context Affects 2021.12.17-2ac19eb, 2021.12.28-a779cdd4, 2021.12.29-4e866dce, 2021.12.31-4a7efcbe, 2022.01.03-ddc26ed, 2022.01.04-8231216, 2022.01.06-5a72824, 2022.01.07-9b134698 (all the builds I have been able to test on). Note that versions before 444b1c9 (2022.01.04-8231216 and earlier) do not display unavailable videos in playlists, while versions after (2022.01.06-5a72824 and later) do. However, the latter versions borrow anyway, so they still have the repetition issue; when affected by it they will display more than 100 videos per block/200 per page. |
This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked. |
Describe the bug
Playlists continuations are broken (again)
Steps to Reproduce
The text was updated successfully, but these errors were encountered: