Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] replace eslint & prettier with biome #77

Closed
9 tasks done
jrson83 opened this issue Sep 26, 2023 · 2 comments
Closed
9 tasks done

[feat] replace eslint & prettier with biome #77

jrson83 opened this issue Sep 26, 2023 · 2 comments
Assignees

Comments

@jrson83
Copy link
Collaborator

jrson83 commented Sep 26, 2023

Description

Replace eslint & prettier with biome.

  • Remove dependencies & recommended extensions
  • Add biome & recommended extension
  • Configure biome with current eslint & prettier config (as close as possible)
  • Replace package.json scripts
  • Run linter check & formatter check
  • Fix any lint errors manually if necessary
  • Ensure build, test etc. working

Additional context

@itsjavi can you please take care of this task, before I create a draft PR:

  • Extract @r1stack/coding-style/jest-preset into a own package, so it does not include any deps. Or alternatively create a one file config, so the root stays clean.
  • Configure lint rules

Current limitations

Since currently the biome extends option is not extending, it is not possible to share multiple configuration files.

@itsjavi
Copy link
Owner

itsjavi commented Sep 27, 2023

@jrson83 done, I extracted all configs from r1stack/coding-style and removed the dependency.

@jrson83
Copy link
Collaborator Author

jrson83 commented Oct 4, 2023

merged

@jrson83 jrson83 closed this as completed Oct 4, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in StoryLite Board Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants