Skip to content

Commit 86ec7b2

Browse files
committed
removing unnecessary linked agent messages
1 parent 7586b27 commit 86ec7b2

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

CHANGELOG.MD

+6
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## [3.3.0-rc20] - 2024-08-23
8+
9+
### Changed
10+
11+
- Updated the delegate checks for socks/rpfwd/interactive messages to only send delegates if there's data
12+
713
## [3.3.0-rc19] - 2024-08-21
814

915
### Changed

VERSION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.3.0-rc19
1+
3.3.0-rc20

mythic-docker/src/VERSION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.3.0-rc19
1+
3.3.0-rc20

mythic-docker/src/rabbitmq/util_agent_message_actions_get_tasking.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ func getDelegateProxyMessages(callbackID int, agentUUIDLength int, updateCheckin
197197
// there's a route between our callback and the target callback for some sort of proxy data
198198
if messages, err := proxyPorts.GetDataForCallbackId(targetCallbackId, CALLBACK_PORT_TYPE_SOCKS); err != nil {
199199
logging.LogError(err, "Failed to get socks proxy data for routable callback")
200-
} else {
200+
} else if messages != nil {
201201
// now that we have a path, need to recursively encrypt and wrap
202202
newTask := map[string]interface{}{
203203
"action": "get_tasking",
@@ -215,7 +215,7 @@ func getDelegateProxyMessages(callbackID int, agentUUIDLength int, updateCheckin
215215
}
216216
if messages, err := proxyPorts.GetDataForCallbackId(targetCallbackId, CALLBACK_PORT_TYPE_RPORTFWD); err != nil {
217217
logging.LogError(err, "Failed to get rpfwd proxy data for routable callback")
218-
} else {
218+
} else if messages != nil {
219219
// now that we have a path, need to recursively encrypt and wrap
220220
newTask := map[string]interface{}{
221221
"action": "get_tasking",
@@ -233,7 +233,7 @@ func getDelegateProxyMessages(callbackID int, agentUUIDLength int, updateCheckin
233233
}
234234
if messages, err := proxyPorts.GetDataForCallbackId(targetCallbackId, CALLBACK_PORT_TYPE_INTERACTIVE); err != nil {
235235
logging.LogError(err, "Failed to get interactive proxy data for routable callback")
236-
} else {
236+
} else if messages != nil {
237237
// now that we have a path, need to recursively encrypt and wrap
238238
newTask := map[string]interface{}{
239239
"action": "get_tasking",

0 commit comments

Comments
 (0)