Skip to content
This repository has been archived by the owner on Jan 5, 2021. It is now read-only.

Design smell in IGenArtifactConfigurations API #912

Closed
wendehals opened this issue Aug 18, 2016 · 2 comments
Closed

Design smell in IGenArtifactConfigurations API #912

wendehals opened this issue Aug 18, 2016 · 2 comments
Assignees
Milestone

Comments

@wendehals
Copy link
Contributor

The interface org.yakindu.sct.generator.c.IGenArtifactConfigurations there is a method

List getConfigurations();

that has a design smell. The type parameter GenArtifactConfiguration of the returned list is actually an inner class of org.yakindu.sct.generator.c.GenArtifactConfigurations that implements IGenArtifactConfigurations. Thus, there is no real decoupling between the interface and its implementation.

Consider to create an interface IGenArtifactConfiguration for the type parameter of the getConfigurations() method.

@tkutz
Copy link
Contributor

tkutz commented Aug 19, 2016

Ok I see, will keep that in mind when refactoring the generators anyways.

@andreasmuelder andreasmuelder added this to the Inbox milestone Aug 19, 2016
@andreasmuelder andreasmuelder self-assigned this Aug 24, 2016
@andreasmuelder
Copy link
Member

done with PR #921

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants