Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spawn wrap blocking release of 11.4.0 #735

Closed
astorije opened this issue Dec 5, 2017 · 8 comments · Fixed by #748
Closed

spawn wrap blocking release of 11.4.0 #735

astorije opened this issue Dec 5, 2017 · 8 comments · Fixed by #748

Comments

@astorije
Copy link

astorije commented Dec 5, 2017

v11.4.0 was released with the dist-tag of next, but npm install picks up latest (default). I added a comment at e8225d5#commitcomment-25987704 about this. Sorry for the duplicate, but I figured a GitHub issue would be more suitable for communicating this.

You need to fiddle with npm dist-tag add and npm dist-tag rm to remove the current tag on v11.4.0 and assign the correct one. This doc explains it well :)

Thanks a lot for your hard work!!

@bcoe
Copy link
Member

bcoe commented Dec 5, 2017

@astorije I haven't released v11.4.0 to latest yet, because there appears to be a Windows issue with spawn-wrap.

@bcoe
Copy link
Member

bcoe commented Dec 5, 2017

see: istanbuljs/spawn-wrap#67

@bcoe bcoe changed the title nyc v11.4.0 is not picked up by npm install nyc spawn wrap blocking release of 11.4.0 Dec 5, 2017
@bcoe
Copy link
Member

bcoe commented Dec 5, 2017

CC: @sridharmallela

@astorije
Copy link
Author

astorije commented Dec 5, 2017

Aaah, my bad, I could have sworn this was a npm publish snafu (this is far from an impossible situation to end up in!). Sorry for the patronization then :)

@sridharmallela
Copy link

@bcoe as spawn-wrap, v1.4.2 resolves shebang issue, can you publish new nyc version, since 11.4 has spawn-wrap as bundled dependency.

@codler
Copy link

codler commented Dec 7, 2017

screen shot 2017-12-07 at 09 57 34

@bcoe
Copy link
Member

bcoe commented Dec 14, 2017

@sridharmallela @astorije @codler could you please give [email protected] a try?

@astorije
Copy link
Author

FYI @bcoe 11.4.0 was fine for me, the missing piece was the complete release.

Things still look 👌 on 11.4.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants