-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Drop node.js 6, upgrade dependencies #1134
Conversation
(edit) I don't think its a bug in this PR. in fact I have no idea why I hit the problem, seems for me I need to specify the path directly in spawn sync rather than just rely on it knowing I don't know if its related to this change or istanbul, but I made instructions to test the master of the instabuljs mono-repo with it dog-fooding its own source, for trying out report changes: https://gist.github.com/lukeapage/c7844b3bd7fab7eed260bfef387848b9 After fixing the none report bug though, it still doesn't work. It looks like the merge command on this pr as run here: doesn't merge, but generates the reports as it might do with normal report generation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking good to me, as soon as those Node 8 tests are passing 👍
spread, how fancy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from me; like Ben said, when the tests are passing it's LGTM!
The issue is not node.js 8, it's Windows (yes, how shocking). I suspect the problem is due to istanbuljs/istanbuljs#422, not sure if this is exposing a failure in test-exclude or if the nyc tests are just wrong for Windows. It's unlikely I'll be able to work on this before next week. |
ef0a328
to
984c4c4
Compare
Finally got around to dealing with the test. Basic issue is that testExclude.shouldInstrument no longer accepts |
No description provided.