Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rimraf doesn't work to remove grunt-contrib-imagemin #74

Closed
emalherbi-zz opened this issue Jun 2, 2015 · 5 comments
Closed

rimraf doesn't work to remove grunt-contrib-imagemin #74

emalherbi-zz opened this issue Jun 2, 2015 · 5 comments

Comments

@emalherbi-zz
Copy link

Hi.

CMD:
win-cmd

PowerShell:
win-shell

@nicothin
Copy link

+1.
error log:

rimraf D:\projects\HTMLACADEMY_advanced-intensive\barbershop\node_modules
C:\Users\nicothin\AppData\Roaming\npm\node_modules\rimraf\rimraf.js:302
throw er
^
Error: ENOTEMPTY, directory not empty 'D:\projects\HTMLACADEMY_advanced-intensive\barbershop\node_modules\grunt-contrib-imagemin\node_modules\imagemin\node_modules\imagemin-gifsicle\node_modules\gifsicle\node_modules\bin-wrapper\node_modules\download\node_modules\vinyl-fs\node_modules\glob-watcher\node_modules\gaze\node_modules\globule\node_modules\minimatch'
at Error (native)
at Object.fs.rmdirSync (fs.js:715:18)
at rmkidsSync (C:\Users\nicothin\AppData\Roaming\npm\node_modules\rimraf\rimraf.js:332:11)
at rmdirSync (C:\Users\nicothin\AppData\Roaming\npm\node_modules\rimraf\rimraf.js:322:7)
at rimrafSync (C:\Users\nicothin\AppData\Roaming\npm\node_modules\rimraf\rimraf.js:293:9)
at C:\Users\nicothin\AppData\Roaming\npm\node_modules\rimraf\rimraf.js:330:5
at Array.forEach (native)
at rmkidsSync (C:\Users\nicothin\AppData\Roaming\npm\node_modules\rimraf\rimraf.js:329:26)
at rmdirSync (C:\Users\nicothin\AppData\Roaming\npm\node_modules\rimraf\rimraf.js:322:7)
at rimrafSync (C:\Users\nicothin\AppData\Roaming\npm\node_modules\rimraf\rimraf.js:293:9)

win 7 64

@Ernesto-Valdes
Copy link

+1

same error on multiple instances for the same grunt-contrib-imagemin node module.

win 7 64

@jorrit
Copy link

jorrit commented Jun 30, 2015

The problem is that the retry mechanisms that should handle this problem is not implemented in the sync version of the command. When starting a REPL node session and invoking rimraf the folder is deleted.

[edit]
I was reading the npm@3 release notes and it seems the deeply nested modules problem is addressed in that version. See https://github.com/npm/npm/releases/tag/v3.0.0

@isaacs
Copy link
Owner

isaacs commented Jun 30, 2015

Yeah, you can't very well retry a sync operation after a bit of a wait.

Perhaps the rimraf binary should be using the async function instead?

@isaacs isaacs closed this as completed in ece14b6 Jun 30, 2015
@vpraveen
Copy link

I had the same problem, but it got fixed as soon as I closed one instance of git bash. Both instances were opened in the same folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants